You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/11 10:24:43 UTC
[GitHub] [airflow] ashb opened a new pull request #9230: Upload kind logs to Github artifacts on failure
ashb opened a new pull request #9230:
URL: https://github.com/apache/airflow/pull/9230
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9230: Upload kind logs to Github artifacts on failure
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#issuecomment-642556807
Based on/using the dump function from #9228, but trying GH Artifacts instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9230: Upload kind logs to Github Actions artifact
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#issuecomment-642714023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb edited a comment on pull request #9230: Upload kind logs to Github Actions artifact
Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#issuecomment-642714023
And they contain
```
❯ unzip -l ~/Downloads/kind-logs-image-3.6-v1.15.3.zip
Archive: /home/ash/Downloads/kind-logs-image-3.6-v1.15.3.zip
Length Date Time Name
--------- ---------- ----- ----
0 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/
0 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/
0 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-worker/
1178 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/docker-info.txt
163605 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/containerd.log
0 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/containers/
10119 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/inspect.json
455966 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/journal.log
275232 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/kubelet.log
7 2020-06-11 14:42 kind_logs_2020-06-11_132248359_tests-kubernetes/airflow-python-3.6-v1.15.3-control-plane/kubernetes-version.txt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #9230: Upload kind logs to Github artifacts on failure
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#discussion_r438720305
##########
File path: .github/workflows/ci.yml
##########
@@ -210,6 +210,11 @@ jobs:
run: ./scripts/ci/ci_perform_kind_cluster_operation.sh start
- name: "Deploy app to cluster"
run: ./scripts/ci/ci_deploy_app_to_kubernetes.sh
+ - uses: actions/upload-artifact@v2
+ if: failure()
Review comment:
(There are some limits on artifacts, 5gb for the whole repo across all builds I think I read somewhere, but if we're only storing compressed text logs it's probably not even close to an issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #9230: Upload kind logs to Github Actions artifact
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #9230:
URL: https://github.com/apache/airflow/pull/9230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #9230: Upload kind logs to Github artifacts on failure
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#discussion_r438720009
##########
File path: .github/workflows/ci.yml
##########
@@ -210,6 +210,11 @@ jobs:
run: ./scripts/ci/ci_perform_kind_cluster_operation.sh start
- name: "Deploy app to cluster"
run: ./scripts/ci/ci_deploy_app_to_kubernetes.sh
+ - uses: actions/upload-artifact@v2
+ if: failure()
Review comment:
Sure can do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9230: Upload kind logs to Github artifacts on failure
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9230:
URL: https://github.com/apache/airflow/pull/9230#discussion_r438703894
##########
File path: .github/workflows/ci.yml
##########
@@ -210,6 +210,11 @@ jobs:
run: ./scripts/ci/ci_perform_kind_cluster_operation.sh start
- name: "Deploy app to cluster"
run: ./scripts/ci/ci_deploy_app_to_kubernetes.sh
+ - uses: actions/upload-artifact@v2
+ if: failure()
Review comment:
One small comment. It would be worth while to remove the if here. Those log might be useful to compare and see success vs. failure. And it does not cost us to have them also on success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org