You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/28 19:03:26 UTC
[GitHub] [samza] lakshmi-manasa-g opened a new pull request #1298:
SAMZA-2476:Fix flaky tests in TestAzureBlobOutputStream
lakshmi-manasa-g opened a new pull request #1298: SAMZA-2476:Fix flaky tests in TestAzureBlobOutputStream
URL: https://github.com/apache/samza/pull/1298
Symptom:
Travis builds occasionally fail with org.mockito.exceptions.misusing.UnfinishedStubbingException for org.apache.samza.system.azureblob.avro.TestAzureBlobOutputStream.testCloseMultipleBlocks.
Cause:
Seems to be due to using PowerMockito.doAnswer for mocking com.azure.storage.blob.specialized.BlockBlobAsyncClient.commitBlockListWithResponse
Changes:
pull call to commitBlockListWithResponse into a package private method of AzureBlobOutputStream and verify that method.
Tests:
Rerun of TestAzureBlobOutputStream in original code cause 240 failures in 10K runs
Rerun of TestAzureBlobOutputStream with this fix causes 0 failures in 10K runs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] rmatharu commented on a change in pull request #1298:
SAMZA-2476:Fix flaky tests in TestAzureBlobOutputStream
Posted by GitBox <gi...@apache.org>.
rmatharu commented on a change in pull request #1298: SAMZA-2476:Fix flaky tests in TestAzureBlobOutputStream
URL: https://github.com/apache/samza/pull/1298#discussion_r385976962
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/avro/AzureBlobOutputStream.java
##########
@@ -227,6 +227,11 @@ public synchronized void releaseBuffer() throws IOException {
this.compression = compression;
}
+ @VisibleForTesting
Review comment:
maybe simple javadoc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] rmatharu merged pull request #1298: SAMZA-2476:Fix flaky
tests in TestAzureBlobOutputStream
Posted by GitBox <gi...@apache.org>.
rmatharu merged pull request #1298: SAMZA-2476:Fix flaky tests in TestAzureBlobOutputStream
URL: https://github.com/apache/samza/pull/1298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services