You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "birschick-bq (via GitHub)" <gi...@apache.org> on 2025/09/03 20:33:57 UTC
[PR] fix(csharp/src/Drivers/Apache/Spark): fix column metadata index offset for Spark standard. [arrow-adbc]
birschick-bq opened a new pull request, #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392
fix column metadata index offset for Spark standard.
Previous calls to GetObjects would throw an "index out of range" exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(csharp/src/Drivers/Apache/Spark): fix column metadata index offset for Spark standard [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392#discussion_r2320143902
##########
csharp/src/Drivers/Apache/Spark/SparkStandardConnection.cs:
##########
@@ -219,6 +219,6 @@ internal override IArrowArrayStream NewReader<T>(T statement, Schema schema, IRe
public override string AssemblyVersion => s_assemblyVersion;
- protected override int ColumnMapIndexOffset => 0;
+ protected override int ColumnMapIndexOffset => 1;
Review Comment:
Can this be moved to `SparkConnection` and removed from both here and `SparkHttpConnection`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(csharp/src/Drivers/Apache/Spark): fix column metadata index offset for Spark standard [arrow-adbc]
Posted by "birschick-bq (via GitHub)" <gi...@apache.org>.
birschick-bq commented on code in PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392#discussion_r2320176131
##########
csharp/src/Drivers/Apache/Spark/SparkStandardConnection.cs:
##########
@@ -219,6 +219,6 @@ internal override IArrowArrayStream NewReader<T>(T statement, Schema schema, IRe
public override string AssemblyVersion => s_assemblyVersion;
- protected override int ColumnMapIndexOffset => 0;
+ protected override int ColumnMapIndexOffset => 1;
Review Comment:
Good call. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(csharp/src/Drivers/Apache/Spark): fix column metadata index offset for Spark standard [arrow-adbc]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org