[GitHub] [airflow] eladkal commented on a diff in pull request #33472: Switch ListJobs to token-based pagination

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #33472:
URL: https://github.com/apache/airflow/pull/33472#discussion_r1297448561


##########
airflow/providers/databricks/hooks/databricks.py:
##########
@@ -156,13 +156,13 @@ def submit_run(self, json: dict) -> int:
         return response["run_id"]
 
     def list_jobs(
-        self, limit: int = 25, offset: int = 0, expand_tasks: bool = False, job_name: str | None = None
+        self, limit: int = 25, page_token: str | None = None, expand_tasks: bool = False, job_name: str | None = None

Review Comment:
   If both `offset` and `page_token` are supported by the API then we need to support them both with raising deprecation warning when using `offset`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org