You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/17 10:33:03 UTC

[GitHub] [doris] liutang123 commented on a diff in pull request #15124: [Pipeline] Add MLFQ when schedule

liutang123 commented on code in PR #15124:
URL: https://github.com/apache/doris/pull/15124#discussion_r1051381510


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -763,13 +763,7 @@ Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params, Fi
             _pipeline_map.insert(std::make_pair(fragment_instance_id, context));
             _cv.notify_all();
         }
-        auto st = context->submit();

Review Comment:
   If task2 submit fail, `In PipelineFragmentContext::submit` will cancel the context and set `_total_tasks` to 1.
   If `_closed_tasks == _total_tasks` represents task1 is close, we try to exec `_close_action`.
   if `_closed_tasks != _total_tasks`, task1 will exec `_close_action`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org