You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/12/19 10:12:52 UTC

[GitHub] nvlsianpu commented on a change in pull request #14: Move platform #ifdefery to

nvlsianpu commented on a change in pull request #14: Move platform #ifdefery to <nffs/os.h>
URL: https://github.com/apache/mynewt-nffs/pull/14#discussion_r242858171
 
 

 ##########
 File path: include/nffs/os.h
 ##########
 @@ -21,9 +21,29 @@
 #define H_OS_
 
 #include <stdint.h>
-#if __ZEPHYR__
+
+#if MYNEWT
+
+#include "fs/fs.h"
+#include "fs/fs_if.h"
+struct fs_ops nffs_ops;
 
 Review comment:
   I would avoid non-static variable definition in common header. Doesn't it generate warning on unused variable in few files here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services