You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/03/23 07:45:50 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8878: assert.h: Replace NULL with 0 to avoid including stddef.h

pkarashchenko commented on code in PR #8878:
URL: https://github.com/apache/nuttx/pull/8878#discussion_r1145794407


##########
include/assert.h:
##########
@@ -66,20 +66,20 @@
     }                                     \
   while (0)
 #else
-#  define ASSERT(f)                         \
-  do                                        \
-    {                                       \
-      if (predict_false(!(f)))              \
-        __assert(__FILE__, __LINE__, NULL); \
-    }                                       \
+#  define ASSERT(f)                       \
+  do                                      \
+    {                                     \
+      if (predict_false(!(f)))            \
+        __assert(__FILE__, __LINE__, 0);  \

Review Comment:
   Will this not lead to an error that integer is passed where the pointer is expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org