You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/08/16 20:12:29 UTC

r15703

Hi,

I wanted to push 1.2.3 a little bit in the right direction by voting on
r15703, but I wanted to verify that it does what it says (I can see that
it avoids accessing an array out-of-bounds).  But I've not been able to
reproduce the problem with 1.2.x on Linux.  I checked out a part of the
tsvn repo from tigris.org and tried to lock a file. I got three
username/password queries, but then it didn't crash.  Does anyone have a
complete recipe?

TIA,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r15703

Posted by steveking <st...@gmx.ch>.
Peter N. Lundblad wrote:
> Hi,
> 
> I wanted to push 1.2.3 a little bit in the right direction by voting on
> r15703, but I wanted to verify that it does what it says (I can see that
> it avoids accessing an array out-of-bounds).  But I've not been able to
> reproduce the problem with 1.2.x on Linux.  I checked out a part of the
> tsvn repo from tigris.org and tried to lock a file. I got three
> username/password queries, but then it didn't crash.  Does anyone have a
> complete recipe?

The recipe is:
$ svn lock file
with client 1.2.1 up to 1.2.2 (and HEAD) can crash if
- the lock is done to a http server 1.1.1 (like tigris.org)
   (seems that it has to be tigris.org, because they use a custom auth 
module)
- the user has the auth data cached on disk
   (just cache username/password on checkout)
- no --username and/or --password is given on the command line

You can find the mail thread with the subject "1.2.2 is not ready [was: 
Re: svn 1.2.2 tarballs are up for testing/voting]"

http://svn.haxx.se/dev/archive-2005-08/0471.shtml

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r15703

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 16 Aug 2005, Mark Phippard wrote:

> "Peter N. Lundblad" <pe...@famlundblad.se> wrote on 08/16/2005 04:12:29
> PM:
>
> > I wanted to push 1.2.3 a little bit in the right direction by voting on
> > r15703, but I wanted to verify that it does what it says (I can see that
> > it avoids accessing an array out-of-bounds).  But I've not been able to
> > reproduce the problem with 1.2.x on Linux.  I checked out a part of the
> > tsvn repo from tigris.org and tried to lock a file. I got three
> > username/password queries, but then it didn't crash.  Does anyone have a
> > complete recipe?
>
> When you ran the lock command, were the credentials still cached?  They
> might need to be in order to get the crash.
>
> When I recreated the problem, I let the svn co command cache the
> credentials.  When I run lock I get three prompts and the last one
> crashes.
>
> This is on Windows.
>
Thanks.  I didn't succeed:-( But I stepped through it with a debugger and
whatched it access the array out-of-bounds, but that didn't lead to a
crash for some reason.  Anyway, I could verify that the patch gets rid of
the out-of-bounds error.  That's enough for me.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r15703

Posted by Mark Phippard <Ma...@softlanding.com>.
"Peter N. Lundblad" <pe...@famlundblad.se> wrote on 08/16/2005 04:12:29 
PM:

> I wanted to push 1.2.3 a little bit in the right direction by voting on
> r15703, but I wanted to verify that it does what it says (I can see that
> it avoids accessing an array out-of-bounds).  But I've not been able to
> reproduce the problem with 1.2.x on Linux.  I checked out a part of the
> tsvn repo from tigris.org and tried to lock a file. I got three
> username/password queries, but then it didn't crash.  Does anyone have a
> complete recipe?

When you ran the lock command, were the credentials still cached?  They 
might need to be in order to get the crash.

When I recreated the problem, I let the svn co command cache the 
credentials.  When I run lock I get three prompts and the last one 
crashes.

This is on Windows.

Mark



_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs. 
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org