You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/03 04:12:26 UTC

[GitHub] [spark] uncleGen commented on issue #24275: [MINOR][SQL][SS] Reorganize packages in streaming sources

uncleGen commented on issue #24275: [MINOR][SQL][SS] Reorganize packages in streaming sources
URL: https://github.com/apache/spark/pull/24275#issuecomment-479331356
 
 
   @srowen Thanks for your reply.
   
   > Would any of those classes be public, and visible to users?
   
   No, there is not any user-visible class changes.
   
   > Also is it not reasonable to call the existing packages "v1" and only put "v2" in new subpackages?
   
   There are some data source implementations located in different packages, and it looks like a little bit confusing. Besides, there are some implementation based on *DataSource V2*. So this PR slightly reorganized these classes. And honestly, I am not totally sure "v1" and "v2" subpackages is a good idea.
   
   Any suggestion is appreciated!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org