You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/08/02 15:17:49 UTC
[GitHub] spark pull request #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTask...
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/21972
[SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext with BarrierTaskContextImpl
## What changes were proposed in this pull request?
According to https://github.com/apache/spark/pull/21758#discussion_r206746905 , current declaration of `BarrierTaskContext` didn't extend methods from `TaskContext`. Since `TaskContext` is an abstract class and we don't want to change it to a trait, we have to define class `BarrierTaskContext` directly.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiangxb1987/spark BarrierTaskContext
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21972
----
commit e5987cf281136528ec0d23f82fe1505abd6545b3
Author: Xingbo Jiang <xi...@...>
Date: 2018-08-02T15:09:37Z
combine BarrierTaskContext with BarrierTaskContextImpl.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94029/testReport)** for PR 21972 at commit [`f3ea13d`](https://github.com/apache/spark/commit/f3ea13d68736cf445d2d72f66cbb2d082a7853bc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1670/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94029/testReport)** for PR 21972 at commit [`f3ea13d`](https://github.com/apache/spark/commit/f3ea13d68736cf445d2d72f66cbb2d082a7853bc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94029/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94018/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94022/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94018/testReport)** for PR 21972 at commit [`e5987cf`](https://github.com/apache/spark/commit/e5987cf281136528ec0d23f82fe1505abd6545b3).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21972
LGTM. Merged into master. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94018/testReport)** for PR 21972 at commit [`e5987cf`](https://github.com/apache/spark/commit/e5987cf281136528ec0d23f82fe1505abd6545b3).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94022/testReport)** for PR 21972 at commit [`f3ea13d`](https://github.com/apache/spark/commit/f3ea13d68736cf445d2d72f66cbb2d082a7853bc).
* This patch **fails from timeout after a configured wait of \`300m\`**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21972
~~~
[error] /home/jenkins/workspace/SparkPullRequestBuilder/core/target/java/org/apache/spark/rdd/RDDBarrier.java:9: error: reference not found
[error] * Maps partitions together with a provided {@link BarrierTaskContext}.
[error]
~~~
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21972
**[Test build #94022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94022/testReport)** for PR 21972 at commit [`f3ea13d`](https://github.com/apache/spark/commit/f3ea13d68736cf445d2d72f66cbb2d082a7853bc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1673/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21972
test this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the issue:
https://github.com/apache/spark/pull/21972
LGTM pending Jenkins.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTaskContext...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21972
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1678/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21972: [SPARK-24795][CORE][FOLLOWUP] Combine BarrierTask...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21972
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org