You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/05/04 03:20:05 UTC
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/12886
[SPARK-15109][SQL] Accept Dataset[_] in joins
## What changes were proposed in this pull request?
This patch changes the join API in Dataset so they can accept any Dataset, rather than just DataFrames.
## How was this patch tested?
N/A.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-15109
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12886
----
commit 59bc92bf9027a4a0c8ec60f9b01dbe4818de4c4b
Author: Reynold Xin <rx...@databricks.com>
Date: 2016-05-04T03:19:00Z
[SPARK-15109][SQL] Accept Dataset[_] in joins
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12886#issuecomment-216741338
**[Test build #57708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57708/consoleFull)** for PR 12886 at commit [`59bc92b`](https://github.com/apache/spark/commit/59bc92bf9027a4a0c8ec60f9b01dbe4818de4c4b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12886#issuecomment-216741547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57708/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12886#issuecomment-216741545
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12886#issuecomment-216943066
Thanks - merging in master/branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12886#issuecomment-216732587
**[Test build #57708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57708/consoleFull)** for PR 12886 at commit [`59bc92b`](https://github.com/apache/spark/commit/59bc92bf9027a4a0c8ec60f9b01dbe4818de4c4b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12886#discussion_r62078478
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -931,8 +931,8 @@ object functions {
* @group normal_funcs
* @since 1.5.0
*/
- def broadcast(df: DataFrame): DataFrame = {
- Dataset.ofRows(df.sparkSession, BroadcastHint(df.logicalPlan))
+ def broadcast[T](df: Dataset[T]): Dataset[T] = {
+ Dataset[T](df.sparkSession, BroadcastHint(df.logicalPlan))(df.unresolvedTEncoder)
--- End diff --
Yes, this looks right. We should get rid of the others now that the resolution logic is in the analyzer. I think they are just there to confuse you at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15109][SQL] Accept Dataset[_] in joins
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12886#discussion_r61986823
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -931,8 +931,8 @@ object functions {
* @group normal_funcs
* @since 1.5.0
*/
- def broadcast(df: DataFrame): DataFrame = {
- Dataset.ofRows(df.sparkSession, BroadcastHint(df.logicalPlan))
+ def broadcast[T](df: Dataset[T]): Dataset[T] = {
+ Dataset[T](df.sparkSession, BroadcastHint(df.logicalPlan))(df.unresolvedTEncoder)
--- End diff --
cc @marmbrus is this the right encoder to use?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org