You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/12/08 21:48:21 UTC

[GitHub] storm pull request #2922: STORM-3301: Fix case where KafkaSpout could emit t...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2922

    STORM-3301: Fix case where KafkaSpout could emit tuples that were alr…

    …eady committed
    
    https://issues.apache.org/jira/browse/STORM-3301
    
    I removed an unnecessary contains check in KafkaSpout during init, it would always return false. I made a slight change to log compaction handling, the spout will now commit an acked offset after a gap, even if it's the only one. Previously there had to be at least 2 acked offsets after the gap before commit.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-3301

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2922.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2922
    
----
commit a657686e150edf3de6942d2b51fe19461d47376a
Author: Stig Rohde Døssing <sr...@...>
Date:   2018-12-08T21:15:04Z

    STORM-3301: Fix case where KafkaSpout could emit tuples that were already committed

----


---

[GitHub] storm issue #2922: STORM-3301: Fix case where KafkaSpout could emit tuples t...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2922
  
    The test failure is due to broken stubbing, I'll fix it soon


---

[GitHub] storm pull request #2922: STORM-3301: Fix case where KafkaSpout could emit t...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2922


---