You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Saurabh Katiyal (Code Review)" <ge...@cloudera.org> on 2024/12/06 12:37:22 UTC
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Saurabh Katiyal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22173
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
IMPALA-13149: Show JVM info in the WebUI
Added a sub-section under "Other Info" in root page for WebUI
which will display JVM info, to be precise output of "java -version"
Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
---
M be/src/util/default-path-handlers.cc
M tests/webserver/test_web_pages.py
M www/root.tmpl
3 files changed, 25 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/22173/2
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:
http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc@275
PS5, Line 275: catalog
nit: "catalogd"
http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc@290
PS5, Line 290: if (!RunShellProcess(cmd, &msg, false, {"JAVA_TOOL_OPTIONS"})) {
I'm a bit concerned on these:
* It seems a waste to launch a new process for each http request just to get the constant version string.
* There are also risks that we show a wrong java version due to JAVA_HOME is not set or incorrectly set. Note that with the dirs of libjvm.so and libjsig.so appear in LD_LIBRARY_PATH, Impala is able to launch.
* We are also lack of test coverage on running this new process in a secured env.
http://gerrit.cloudera.org:8080/#/c/22173/5/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/22173/5/tests/webserver/test_web_pages.py@128
PS5, Line 128: catalog
nit: "catalogd"
http://gerrit.cloudera.org:8080/#/c/22173/5/tests/webserver/test_web_pages.py@132
PS5, Line 132: assert "java_version" in root_page_json
Can we simply merge this to the above test?
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 09:25:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11312/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:51:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 7:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/18151/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 18:31:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11435/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 8
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 17:12:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:
http://gerrit.cloudera.org:8080/#/c/22173/5/be/src/util/default-path-handlers.cc@290
PS5, Line 290: if (!RunShellProcess(cmd, &msg, false, {"JAVA_TOOL_OPTIONS"})) {
> I'm a bit concerned on these:
Here is a way to launch impalad without setting JAVA_HOME:
Launch the minicluster and use "killall impalad" to kill all impalad processes.
Open a new terminal and go into the IMPALA_HOME folder. Don't source bin/impala-config.sh. Set the env vars manually:
export IMPALA_HOME=/home/quanlong/workspace/Impala
export CLASSPATH="${IMPALA_HOME}/fe/target/dependency/*:${IMPALA_HOME}/fe/src/test/resources:${IMPALA_HOME}/fe/target/*"
export LD_LIBRARY_PATH="$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/lib64:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/kudu-e742f86f6d/debug/lib:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/kudu-e742f86f6d/debug/lib64:$IMPALA_HOME/toolchain/toolchain-packages-gcc10.4.0/gcc-10.4.0/lib64:/home/quanlong/software/jdk-11.0.25/lib/server/"
export LIBHDFS_OPTS=" -Djava.library.path=/home/quanlong/workspace/Impala/toolchain/cdp_components-58457853/hadoop-3.1.1.7.3.1.0-160/lib/native/ -XX:ErrorFile=/home/quanlong/workspace/Impala/logs/hs_err_pid%p.log -XX:MaxPermSize=128m"
Launch impalad by
$IMPALA_HOME/be/build/latest/service/impalad -v=1 -log_filename=impalad -log_dir=$IMPALA_HOME/logs/cluster
Note that I add JDK11 in LD_LIBRARY_PATH so impalad is actually using JDK11. However, the default "java" in my OS is java8. So the WebUI is showing the version of Java8 which is wrong.
A possible way to fix this is using something like JniUtil::GetJNIEnv()->GetVersion(). This returns an int. Maybe we can construct the java version string using info like this.
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 09:36:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11385/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 10:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 8:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11435/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 8
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 10 Feb 2025 22:42:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11393/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:41:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 7:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11393/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 16:20:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11403/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 8
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 07:54:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Saurabh Katiyal (Code Review)" <ge...@cloudera.org>.
Saurabh Katiyal has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
IMPALA-13149: Show JVM info in the WebUI
Added a sub-section under "Other Info" in root page for WebUI
which will display JVM info, to be precise output of "java -version"
Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
---
M be/src/util/default-path-handlers.cc
M tests/webserver/test_web_pages.py
M www/root.tmpl
3 files changed, 38 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/22173/4
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2024 19:34:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22173/2/be/src/util/default-path-handlers.cc
File be/src/util/default-path-handlers.cc:
http://gerrit.cloudera.org:8080/#/c/22173/2/be/src/util/default-path-handlers.cc@327
PS2, Line 327: Value java_version(GetJavaVersion().c_str(), document->GetAllocator());
: document->AddMember("java_version", java_version, document->GetAllocator());
Can we only run this for catalogd and impalad? statestore and admissiond don't depend on Java so might not have this info.
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Dec 2024 07:08:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11306/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 18:35:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11306/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 11 Jan 2025 00:07:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 01:13:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11385/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 03 Feb 2025 16:04:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/17922/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jan 2025 18:51:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11303/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 18:05:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11303/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 5
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 12:31:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17623/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2024 13:04:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11187/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 2
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Dec 2024 14:00:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Saurabh Katiyal (Code Review)" <ge...@cloudera.org>.
Saurabh Katiyal has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
IMPALA-13149: Show JVM info in the WebUI
Added a sub-section under "Other Info" in root page for WebUI
which will display JVM info, to be precise output of "java -version"
Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
---
M be/src/util/default-path-handlers.cc
M tests/webserver/test_web_pages.py
M www/root.tmpl
3 files changed, 56 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/22173/7
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 7
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13149: Show JVM info in the WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22173 )
Change subject: IMPALA-13149: Show JVM info in the WebUI
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11403/
--
To view, visit http://gerrit.cloudera.org:8080/22173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee03a05af9f0c5c2a7ab108ade503c6131bfe414
Gerrit-Change-Number: 22173
Gerrit-PatchSet: 8
Gerrit-Owner: Saurabh Katiyal <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 13:18:48 +0000
Gerrit-HasComments: No