You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2023/08/11 17:37:55 UTC
[GitHub] [avro] sarutak opened a new pull request, #2437: AVRO-3830: [Rust] Handle namespace properly if a name starts with dot
sarutak opened a new pull request, #2437:
URL: https://github.com/apache/avro/pull/2437
AVRO-3830
## What is the purpose of the change
This PR aims to fix an issue that the current Rust binding doesn't handle namespaces properly if a name starts with dot.
[The specification](https://avro.apache.org/docs/1.11.1/specification/#names) says about the name and namespace like as follows.
> The empty string may also be used as a namespace to indicate the null namespace
> If the name specified contains a dot, then it is assumed to be a fullname, and any namespace also specified is ignored
According to this specification, if a name in a name field starts with a dot, it's considered that the namespace is null and the corresponding namespace field should be ignored.
For example, given the following schema.
```
{
"name": ".record1",
"namespace": "ns1",
"type": "record",
"fields": []
}
```
The name and namespace should be "record1" and null respectively.
But the namespace is considered as "ns1" in the current Rust binding .
## Verifying this change
Added new test.
## Documentation
No new features added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #2437: AVRO-3830: [Rust] Handle namespace properly if a name starts with dot
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #2437:
URL: https://github.com/apache/avro/pull/2437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #2437: AVRO-3830: [Rust] Handle namespace properly if a name starts with dot
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2437:
URL: https://github.com/apache/avro/pull/2437#issuecomment-1678476321
Thank you, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org