You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/11 18:15:50 UTC
[GitHub] [maven] AlexanderAshitkin opened a new pull request #609: Maven-Core changes to support cache extension
AlexanderAshitkin opened a new pull request #609:
URL: https://github.com/apache/maven/pull/609
CC @ansip
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin closed pull request #609: [MNG-7129] Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin closed pull request #609:
URL: https://github.com/apache/maven/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #609: Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on a change in pull request #609:
URL: https://github.com/apache/maven/pull/609#discussion_r747727935
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -135,21 +139,26 @@ else if ( Artifact.SCOPE_TEST.equals( classpath ) )
return Collections.unmodifiableCollection( scopes );
}
- public void execute( MavenSession session, List<MojoExecution> mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public void execute( final MavenSession session,
+ List<MojoExecution> mojoExecutions,
+ final ProjectIndex projectIndex ) throws LifecycleExecutionException
{
- DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
+ final DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
- PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
+ final PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
- for ( MojoExecution mojoExecution : mojoExecutions )
+ mojoExecutionStrategy.execute( session, mojoExecutions, new MojoExecutionStrategy.Executor( )
{
- execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
- }
+ @Override
+ public void execute( MojoExecution mojoExecution ) throws LifecycleExecutionException
+ {
+ MojoExecutor.this.execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
+ }
+ } );
}
- public void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
+ private void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
Review comment:
this class is not a part of public api - but if someone used it in extension this is potentially breaking. will be good to no - good or not to go with visibility change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #609: Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on a change in pull request #609:
URL: https://github.com/apache/maven/pull/609#discussion_r747727935
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -135,21 +139,26 @@ else if ( Artifact.SCOPE_TEST.equals( classpath ) )
return Collections.unmodifiableCollection( scopes );
}
- public void execute( MavenSession session, List<MojoExecution> mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public void execute( final MavenSession session,
+ List<MojoExecution> mojoExecutions,
+ final ProjectIndex projectIndex ) throws LifecycleExecutionException
{
- DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
+ final DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
- PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
+ final PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
- for ( MojoExecution mojoExecution : mojoExecutions )
+ mojoExecutionStrategy.execute( session, mojoExecutions, new MojoExecutionStrategy.Executor( )
{
- execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
- }
+ @Override
+ public void execute( MojoExecution mojoExecution ) throws LifecycleExecutionException
+ {
+ MojoExecutor.this.execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
+ }
+ } );
}
- public void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
+ private void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
Review comment:
this class is not a part of public api - but if someone used it in extension this is potentially breaking. will be good to no - good not good to go with visibility change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #609: Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #609:
URL: https://github.com/apache/maven/pull/609#issuecomment-966527950
I think this should have a JIRA issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #609: Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on a change in pull request #609:
URL: https://github.com/apache/maven/pull/609#discussion_r747727935
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -135,21 +139,26 @@ else if ( Artifact.SCOPE_TEST.equals( classpath ) )
return Collections.unmodifiableCollection( scopes );
}
- public void execute( MavenSession session, List<MojoExecution> mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public void execute( final MavenSession session,
+ List<MojoExecution> mojoExecutions,
+ final ProjectIndex projectIndex ) throws LifecycleExecutionException
{
- DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
+ final DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
- PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
+ final PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
- for ( MojoExecution mojoExecution : mojoExecutions )
+ mojoExecutionStrategy.execute( session, mojoExecutions, new MojoExecutionStrategy.Executor( )
{
- execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
- }
+ @Override
+ public void execute( MojoExecution mojoExecution ) throws LifecycleExecutionException
+ {
+ MojoExecutor.this.execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
+ }
+ } );
}
- public void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
+ private void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
Review comment:
this class is not a part of public api - but if someone used it in extension this is potentially breaking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin closed pull request #609: [MNG-7129] Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin closed pull request #609:
URL: https://github.com/apache/maven/pull/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #609: Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on a change in pull request #609:
URL: https://github.com/apache/maven/pull/609#discussion_r747727935
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoExecutor.java
##########
@@ -135,21 +139,26 @@ else if ( Artifact.SCOPE_TEST.equals( classpath ) )
return Collections.unmodifiableCollection( scopes );
}
- public void execute( MavenSession session, List<MojoExecution> mojoExecutions, ProjectIndex projectIndex )
- throws LifecycleExecutionException
+ public void execute( final MavenSession session,
+ List<MojoExecution> mojoExecutions,
+ final ProjectIndex projectIndex ) throws LifecycleExecutionException
{
- DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
+ final DependencyContext dependencyContext = newDependencyContext( session, mojoExecutions );
- PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
+ final PhaseRecorder phaseRecorder = new PhaseRecorder( session.getCurrentProject() );
- for ( MojoExecution mojoExecution : mojoExecutions )
+ mojoExecutionStrategy.execute( session, mojoExecutions, new MojoExecutionStrategy.Executor( )
{
- execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
- }
+ @Override
+ public void execute( MojoExecution mojoExecution ) throws LifecycleExecutionException
+ {
+ MojoExecutor.this.execute( session, mojoExecution, projectIndex, dependencyContext, phaseRecorder );
+ }
+ } );
}
- public void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
+ private void execute( MavenSession session, MojoExecution mojoExecution, ProjectIndex projectIndex,
Review comment:
this class is not a part of public api - but if someone used it in extension this is potentially breaking. will be good to decide - good or not to go with this visibility change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] AlexanderAshitkin commented on pull request #609: [MNG-7129] Maven-Core changes to support cache extension
Posted by GitBox <gi...@apache.org>.
AlexanderAshitkin commented on pull request #609:
URL: https://github.com/apache/maven/pull/609#issuecomment-966813564
> I think this should have a JIRA issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org