You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:46:57 UTC

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2575: Changes in the watchdog auto-monitor menu

saramonteiro opened a new pull request #2575:
URL: https://github.com/apache/incubator-nuttx/pull/2575


   ## Summary
   
   I have some suggestions for change for the Watchdog Timer Support Menu.
   
   1. The first suggestion is to set the Keep alive interval to depend on the Auto-Monitor choice. Because this interval is only really used by the Timer Callback option or Worker callback option. So it may cause confusion to NuttX users. 
   2. Although the dev path is not within the Auto-monitor menu, It seems that the Watchdog Device Path is going to determine which WDT will be fed by the auto-monitor, which is not true. Because if the Auto-monitor is enabled, it will feed all WDTs registered as character drivers.
   
   ## Impact
   All Auto-monitor users.
   
   ## Testing
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2575: Changes in the watchdog auto-monitor menu

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2575:
URL: https://github.com/apache/incubator-nuttx/pull/2575


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #2575: Changes in the watchdog auto-monitor menu

Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #2575:
URL: https://github.com/apache/incubator-nuttx/pull/2575#issuecomment-748934154


   Hey @xiaoxiang781216 
   The patch that I suggested in the email.
   Please, if you can, take a look.
   Thank you! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org