You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/08 20:34:53 UTC

[GitHub] [geode-native] dgkimura commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

dgkimura commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r485147471



##########
File path: cppcache/benchmark/GeodeLoggingBM.cpp
##########
@@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash;
 
 const int STRING_ARRAY_LENGTH = 3;
 
-int g_iteration = 0;
+static int g_iteration = 0;

Review comment:
       Does `static` here have the same effect as declaring this in an anonymous namespace?  If so, seems that might be the more standard paradigm here, `static` feels more of a C remanent to me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org