You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/18 21:35:58 UTC
[kudu-CR] iwyu: run IWYU on multiple cores
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10104
to review the following change.
Change subject: iwyu: run IWYU on multiple cores
......................................................................
iwyu: run IWYU on multiple cores
This changes iwyu_tool to use a number of parallel IWYU processes equal
to the number of cores, resulting in a huge speedup for common dev
workflows.
Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
---
M build-support/iwyu/iwyu_tool.py
1 file changed, 22 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/10104/1
--
To view, visit http://gerrit.cloudera.org:8080/10104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
Gerrit-Change-Number: 10104
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] iwyu: run IWYU on multiple cores
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10104 )
Change subject: iwyu: run IWYU on multiple cores
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
Gerrit-Change-Number: 10104
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 18 Apr 2018 21:48:50 +0000
Gerrit-HasComments: No
[kudu-CR] iwyu: run IWYU on multiple cores
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10104 )
Change subject: iwyu: run IWYU on multiple cores
......................................................................
Patch Set 1:
That looks great! Now it should be much faster.
--
To view, visit http://gerrit.cloudera.org:8080/10104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
Gerrit-Change-Number: 10104
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 18 Apr 2018 22:55:44 +0000
Gerrit-HasComments: No
[kudu-CR] iwyu: run IWYU on multiple cores
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10104 )
Change subject: iwyu: run IWYU on multiple cores
......................................................................
iwyu: run IWYU on multiple cores
This changes iwyu_tool to use a number of parallel IWYU processes equal
to the number of cores, resulting in a huge speedup for common dev
workflows.
Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
Reviewed-on: http://gerrit.cloudera.org:8080/10104
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/iwyu/iwyu_tool.py
1 file changed, 22 insertions(+), 10 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I97206318943b408c6fdd5637c6ccb79ee4d87d3f
Gerrit-Change-Number: 10104
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>