You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2012/05/23 17:10:02 UTC

git commit: Fix incorrectly constructed feature method

Updated Branches:
  refs/heads/master 6e16b6eeb -> 8224aae21


Fix incorrectly constructed feature method


Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/8224aae2
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/8224aae2
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/8224aae2

Branch: refs/heads/master
Commit: 8224aae21d746c1b42846fe983b1254b17e4f070
Parents: 6e16b6e
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Wed May 23 08:09:56 2012 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Wed May 23 08:09:56 2012 -0700

----------------------------------------------------------------------
 .../services/FilterMethodAnalyzerSpec.groovy       |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/8224aae2/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy b/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy
index 93afb73..5f5f9ef 100644
--- a/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy
+++ b/tapestry-ioc/src/test/groovy/org/apache/tapestry5/ioc/internal/services/FilterMethodAnalyzerSpec.groovy
@@ -3,17 +3,19 @@ package org.apache.tapestry5.ioc.internal.services
 import spock.lang.Specification
 import spock.lang.Unroll
 
-
 class FilterMethodAnalyzerSpec extends Specification {
 
-  def find(clazz, name) {
+  private MethodSignature find(clazz, name) {
     new MethodSignature(clazz.methods.find { it.name == name })
   }
 
   @Unroll
-  def "position of delegate parameter for #filterMethod should be #position"() {
+  def "position of delegate parameter for #methodName should be #position"() {
     def analyzer = new FilterMethodAnalyzer(SampleService)
 
+    def mainMethod = find SampleService, methodName
+    def filterMethod = find SampleFilter, methodName
+
     expect:
 
     analyzer.findServiceInterfacePosition(mainMethod, filterMethod) == position
@@ -27,7 +29,5 @@ class FilterMethodAnalyzerSpec extends Specification {
     "missingServiceInterface" | -1
     "complexMatch"            | 2
 
-    mainMethod = find SampleService, methodName
-    filterMethod = find SampleFilter, methodName
   }
 }