You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sigma-Ma (via GitHub)" <gi...@apache.org> on 2026/07/22 06:33:08 UTC

[PR] HBASE-30092 Avoid stringifying protobuf RPC parameters in task snapshots [hbase]

Sigma-Ma opened a new pull request, #8489:
URL: https://github.com/apache/hbase/pull/8489

   JIRA: https://issues.apache.org/jira/browse/HBASE-30092
   
   ### What changes were proposed in this pull request?
   
   This change avoids calling `Message.toString()` when `MonitoredRPCHandlerImpl` generates RPC monitoring information.
   
   For protobuf parameters, HBase now records only the protobuf message type, such as `ScanRequest`. The existing `packetlength` field continues to report the serialized request size.
   
   ### Why are the changes needed?
   
   HBASE-30092 reports that `MonitoredRPCHandlerImpl.generateCallInfoMap()` can cause an out-of-memory error while generating RegionServer heartbeat information for a large in-flight RPC request.
   
   Calling `toString()` on a protobuf recursively materializes the complete TextFormat representation. For large RPC requests, this creates a significant additional allocation in the monitoring path and can exhaust the RegionServer heap.
   
   Recording only the protobuf message type keeps monitoring allocation independent of the request payload size while preserving the RPC method and serialized packet length.
   
   ### How was this patch tested?
   
   Added a regression test to `TestTaskMonitor`, covering:
   
   - Cloning a monitored RPC containing a large protobuf `ScanRequest`.
   - The RPC parameters contain only the protobuf message type.
   - The serialized packet length is preserved.
   
   The focused unit test can be run with:
   
   ```bash
   mvn -pl hbase-server -am \
     -DskipITs \
     '-Dtest=TestTaskMonitor#testCloneDoesNotStringifyProtobufParams' \
     -Dsurefire.failIfNoSpecifiedTests=false \
     test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30092 Avoid stringifying protobuf RPC parameters in task snapshots [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8489:
URL: https://github.com/apache/hbase/pull/8489#issuecomment-5364773631

   Hi @Apache9, sorry for the direct ping.
   
   This small HBASE-30092 fix has been open for about a month and currently has no reviewer. All three GitHub Actions checks are green, and the PR is mergeable.
   
   The change avoids stringifying large in-flight protobuf requests in MonitoredRPCHandlerImpl, preventing the RPC monitoring and RegionServer heartbeat path from causing excessive heap allocation. A focused regression test is included.
   
   Could you please take a look when convenient, or suggest a more appropriate reviewer?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30092 Avoid stringifying protobuf RPC parameters in task snapshots [hbase]

Posted by "PDavid (via GitHub) via issues" <is...@hbase.apache.org>.
PDavid commented on PR #8489:
URL: https://github.com/apache/hbase/pull/8489#issuecomment-7045492362

   Can you maybe also take a look @liuxiaocs7?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30092 Avoid stringifying protobuf RPC parameters in task snapshots [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8489:
URL: https://github.com/apache/hbase/pull/8489#issuecomment-5065687352

   Hi maintainers, the three GitHub Actions workflows for this fork PR are awaiting approval. This PR does not modify any workflow files.
   
   Could someone with write access approve them when convenient? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30092 Avoid stringifying protobuf RPC parameters in task snapshots [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8489:
URL: https://github.com/apache/hbase/pull/8489#issuecomment-5174057086

   Hi @liuxiaocs7, sorry for the direct ping.
   
   This small HBASE-30092 fix is currently blocked because the three fork workflows still require maintainer approval. It avoids stringifying large protobuf RPC parameters in MonitoredRPCHandlerImpl and includes a focused regression test.
   
   Could you please approve the workflows and take a look when convenient, or suggest a more appropriate reviewer?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org