You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/04 13:54:00 UTC

[jira] [Commented] (KAFKA-6004) Enable custom authentication plugins to return error messages to clients

    [ https://issues.apache.org/jira/browse/KAFKA-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191285#comment-16191285 ] 

ASF GitHub Bot commented on KAFKA-6004:
---------------------------------------

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/4015

    KAFKA-6004: Allow authentication providers to override error message

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-6004-auth-exception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4015
    
----
commit 8cbbbae3f3da625856db27b2fdf4004c9980931e
Author: Rajini Sivaram <ra...@googlemail.com>
Date:   2017-10-04T13:27:30Z

    KAFKA-6004: Allow authentication providers to override error message

----


> Enable custom authentication plugins to return error messages to clients
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-6004
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6004
>             Project: Kafka
>          Issue Type: Improvement
>          Components: security
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>             Fix For: 1.0.1
>
>
> KIP-152 enables authentication failures to be returned to clients to simplify diagnosis of security configuration issues. At the moment, a fixed message is returned to clients by SaslServerAuthenticator which says "Authentication failed due to invalid credentials with SASL mechanism $mechanism".
> We have added an error message string to SaslAuthenticateResponse to return custom messages from the broker to clients. Custom SASL server implementations may want to return more specific error messages in some cases. We should allow this by returning error messages from specific exceptions (e.g. org.apache.kafka.common.errors.AuthenticationException) in SaslAuthenticateResponse. It would be better not to return the error message from SaslException since it may contain information that we do not want to leak to clients.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)