[jira] [Commented] (HDDS-4272) Volume namespace: add namespaceQuotaUsage and update it when create and delete bucket

["Rui Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242804#comment-17242804 ] 

Rui Wang commented on HDDS-4272:
--------------------------------

[~captainzmc]
Hi Mingchao,

I want to follow up on your comment: https://github.com/apache/ozone/pull/1445#issuecomment-733494241

So from https://github.com/apache/ozone/pull/1489, I can see that `usedBytes` are moved to OMBucketInfo. And in those changing states requests, I see that the write lock on BUCKET_LOCK is required.

My current understanding is I also need to move `usedNamespace` to OMBucketInfo. And in OMBucketCreateRequest and OMBucketDeleteRequest, write lock on BUCKET_LOCK is acquired so OMBucketInfo can be modified to incr/decr `usedNamespace`

This seems straightforward for OMBucketCreateRequest, because OMBucketInfo will be added to response then submitted to double buffer: https://github.com/apache/ozone/blob/f1e46cb25f815ff857ecb4e4fc9ab44395a65943/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java#L214

However, for OMBucketDeleteRequest, the response does not contain OMBucketInfo: https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketDeleteRequest.java#L138

So if so far my understanding is correct, I will have to add OMBucketInfo as a part of OMBucketDeleteResponse. Does this sound right to you?

> Volume namespace: add namespaceQuotaUsage and update it when create and delete bucket
> -------------------------------------------------------------------------------------
>
>                 Key: HDDS-4272
>                 URL: https://issues.apache.org/jira/browse/HDDS-4272
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org