You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-commits@incubator.apache.org by aw...@apache.org on 2006/09/25 23:46:15 UTC

svn commit: r449865 - /incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java

Author: awiner
Date: Mon Sep 25 16:46:14 2006
New Revision: 449865

URL: http://svn.apache.org/viewvc?view=rev&rev=449865
Log:
Clean up a comment to include an explanation instead of a reference to an Oracle bug number

Modified:
    incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java

Modified: incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java
URL: http://svn.apache.org/viewvc/incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java?view=diff&rev=449865&r1=449864&r2=449865
==============================================================================
--- incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java (original)
+++ incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/application/StateManagerImpl.java Mon Sep 25 16:46:14 2006
@@ -372,7 +372,12 @@
       if (root != null)
       {
         _LOG.finer("UIViewRoot for token {0} already exists. Bypassing restoreState", token);
-        // we need to create a new UIViewRoot because of bug 4719021:
+        // we need to create a new UIViewRoot because JSF 1.1 does not
+        // clear FacesEvents (or FacesMessages, IIRC), so any pending
+        // events will still be present.
+        // TODO this should probably be using UIViewRoot.saveState()
+        // and restoreState(), and using Application.createComponent()
+        // instead of new UIViewRoot()
         UIViewRoot newRoot = new UIViewRoot();
         newRoot.setId(root.getId());
         newRoot.setLocale(root.getLocale());