You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/10 22:04:25 UTC

[GitHub] [spark] HeartSaVioR opened a new pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

HeartSaVioR opened a new pull request #28790:
URL: https://github.com/apache/spark/pull/28790


   ### What changes were proposed in this pull request?
   
   This PR proposes to remove package private in classes/objects in sql.execution package, as per SPARK-16964.
   
   ### Why are the changes needed?
   
   This is per post-hoc review comment, see https://github.com/apache/spark/pull/24996#discussion_r437126445
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642386793


   **[Test build #123815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123815/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642293974


   **[Test build #123787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123787/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642473599


   Thanks all for reviewing and merging!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642293974


   **[Test build #123787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123787/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642294729






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642383726


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123787/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642383125


   **[Test build #123787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123787/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class ProcessingTimeTrigger(intervalMs: Long) extends Trigger `
     * `case class ContinuousTrigger(intervalMs: Long) extends Trigger `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642454974






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642383717






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642294729






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642291660


   cc. @HyukjinKwon 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642383717


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642387058






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642454982


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123815/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642386793


   **[Test build #123815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123815/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642387058






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642399726


   Since this is not related to UT running, merged to master/3.0. Thank you all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642392791


   Made a PR for https://github.com/apache/spark/pull/28790#issuecomment-642383125, https://github.com/apache/spark/pull/28798


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HeartSaVioR commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642385337


   retest this, please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642454616


   **[Test build #123815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123815/testReport)** for PR 28790 at commit [`7e9bfdf`](https://github.com/apache/spark/commit/7e9bfdfd166eb73a7c04d4d7cab7bcfcd55e6473).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class ProcessingTimeTrigger(intervalMs: Long) extends Trigger `
     * `case class ContinuousTrigger(intervalMs: Long) extends Trigger `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28790:
URL: https://github.com/apache/spark/pull/28790


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28790: [SPARK-28199][SS][FOLLOWUP] Remove package private in class/object in sql.execution package

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28790:
URL: https://github.com/apache/spark/pull/28790#issuecomment-642454974


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org