[incubator-heron] branch master updated: Make 0 stat visible in Heron UI (#3192)

[nw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

nwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git


The following commit(s) were added to refs/heads/master by this push:
     new 2e498cb  Make 0 stat visible in Heron UI (#3192)
2e498cb is described below

commit 2e498cbfb93d76591b890bc1f4ca1d5f4e855e9f
Author: Ning Wang <nw...@twitter.com>
AuthorDate: Mon Feb 11 12:39:16 2019 -0800

    Make 0 stat visible in Heron UI (#3192)
    
    * Make 0 stat visible in Heron UI
---
 heron/tools/ui/resources/static/js/stat-trendlines.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/heron/tools/ui/resources/static/js/stat-trendlines.js b/heron/tools/ui/resources/static/js/stat-trendlines.js
index b1569c1..964f0cf 100644
--- a/heron/tools/ui/resources/static/js/stat-trendlines.js
+++ b/heron/tools/ui/resources/static/js/stat-trendlines.js
@@ -133,7 +133,9 @@ function StatTrendlines(baseUrl, cluster, environ, toponame, physicalPlan, logic
           .attr('y2', rowHeight);
       var yScale = d3.scale.linear()
         .domain(extent)
-        .range([rowHeight, 0]);
+        // yScale starts from 1 so that value 0 is visible and users can tell
+        // if metrics are loaded or not
+        .range([rowHeight - 1, 0]);
 
       // request data and render the line chart
       (metric.queryTrendline || makeTrendlineQuery)(metric, name, instance, startTime, endTime, function (data) {