You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Stefano Bagnara <ap...@bago.org> on 2008/05/12 10:57:18 UTC

[jSieve] sieveConfig.xml and commons-digester dependency

 From a fast overview of jSieve I noticed that jSieve now have the 
following dependencies:
commons-logging
commons-digester
commons-beanutils

jakarta-oro is no more there after JSIEVE-19 resolution.

I noticed that commons-digester and commons-beanutils are there only to 
allow the ConfigurationManager (used by CommandManager, 
ComparatorManager and TestManager) to read sieveConfig.xml.

sieveConfig.xml simply defines 3 "string to string" maps (we do 
something very similar in jSPF for the supported terms map)

Does it worth replacing this with 3 simple properties files so to remove 
any dependency but commons-logging?

commandsmap.properties
----
if=org.apache.jsieve.commands.If
else=org.apache.jsieve.commands.Else
elsif=org.apache.jsieve.commands.Elsif
require=org.apache.jsieve.commands.Require
stop=org.apache.jsieve.commands.Stop
# RFC3082 - Implementations MUST support these
keep=org.apache.jsieve.commands.Keep
discard=org.apache.jsieve.commands.Discard
redirect=org.apache.jsieve.commands.Redirect
# RFC3082 - Implementations SHOULD support these
reject=org.apache.jsieve.commands.optional.Reject
fileinto=org.apache.jsieve.commands.optional.FileInto
# JUnit Commands for Testing
throwtestexception=org.apache.jsieve.junit.commands.ThrowTestException
# Extension Commands
log=org.apache.jsieve.commands.extensions.Log

testsmap.properties
----
# RFC3082 - Implementations MUST support these tests
address=org.apache.jsieve.tests.Address
allof=org.apache.jsieve.tests.AllOf
anyof=org.apache.jsieve.tests.AnyOf
exists=org.apache.jsieve.tests.Exists
false=org.apache.jsieve.tests.False
header=org.apache.jsieve.tests.Header
not=org.apache.jsieve.tests.Not
size=org.apache.jsieve.tests.Size
true=org.apache.jsieve.tests.True
# RFC3082 - Implementations SHOULD support these
envelope=org.apache.jsieve.tests.optional.Envelope
# Limited implementation
body=org.apache.jsieve.tests.optional.Body

comparatorsmap.properties
----
# RFC3082 - Implementations MUST support these
i;octet=org.apache.jsieve.comparators.Octet
i;ascii-casemap=org.apache.jsieve.comparators.AsciiCasemap


Stefano


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jSieve] sieveConfig.xml and commons-digester dependency

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Mon, May 12, 2008 at 9:57 AM, Stefano Bagnara <ap...@bago.org> wrote:
> From a fast overview of jSieve I noticed that jSieve now have the following
> dependencies:
>  commons-logging
>  commons-digester
>  commons-beanutils
>
>  jakarta-oro is no more there after JSIEVE-19 resolution.
>
>  I noticed that commons-digester and commons-beanutils are there only to
> allow the ConfigurationManager (used by CommandManager, ComparatorManager
> and TestManager) to read sieveConfig.xml.
>
>  sieveConfig.xml simply defines 3 "string to string" maps (we do something
> very similar in jSPF for the supported terms map)
>
>  Does it worth replacing this with 3 simple properties files so to remove
> any dependency but commons-logging?

i think so

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org