You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2022/09/07 19:14:03 UTC
[superset] 01/01: 3 act errors removed from FaveStar test
This is an automated email from the ASF dual-hosted git repository.
lyndsi pushed a commit to branch lyndsi/favestar-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git
commit bb4f4375604c1af1ea1e3470521ea364a6082170
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Wed Sep 7 14:13:24 2022 -0500
3 act errors removed from FaveStar test
---
.../src/components/FaveStar/FaveStar.test.tsx | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/superset-frontend/src/components/FaveStar/FaveStar.test.tsx b/superset-frontend/src/components/FaveStar/FaveStar.test.tsx
index 68433db96e..136abd3eaf 100644
--- a/superset-frontend/src/components/FaveStar/FaveStar.test.tsx
+++ b/superset-frontend/src/components/FaveStar/FaveStar.test.tsx
@@ -26,13 +26,13 @@ jest.mock('src/components/Tooltip', () => ({
Tooltip: (props: any) => <div data-test="tooltip" {...props} />,
}));
-test('render right content', () => {
+it('render right content', async () => {
const props = {
itemId: 3,
saveFaveStar: jest.fn(),
};
- const { rerender } = render(<FaveStar {...props} isStarred />);
+ const { rerender, findByRole } = render(<FaveStar {...props} isStarred />);
expect(screen.getByRole('button')).toBeInTheDocument();
expect(
screen.getByRole('img', { name: 'favorite-selected' }),
@@ -45,7 +45,7 @@ test('render right content', () => {
rerender(<FaveStar {...props} />);
expect(
- screen.getByRole('img', { name: 'favorite-unselected' }),
+ await findByRole('img', { name: 'favorite-unselected' }),
).toBeInTheDocument();
expect(props.saveFaveStar).toBeCalledTimes(1);
@@ -54,7 +54,7 @@ test('render right content', () => {
expect(props.saveFaveStar).toBeCalledWith(props.itemId, false);
});
-test('render content on tooltip', () => {
+it('render content on tooltip', async () => {
const props = {
itemId: 3,
showTooltip: true,
@@ -63,7 +63,7 @@ test('render content on tooltip', () => {
render(<FaveStar {...props} />);
- expect(screen.getByTestId('tooltip')).toBeInTheDocument();
+ expect(await screen.findByTestId('tooltip')).toBeInTheDocument();
expect(screen.getByTestId('tooltip')).toHaveAttribute(
'id',
'fave-unfave-tooltip',
@@ -75,7 +75,7 @@ test('render content on tooltip', () => {
expect(screen.getByRole('button')).toBeInTheDocument();
});
-test('Call fetchFaveStar only on the first render', () => {
+it('Call fetchFaveStar only on the first render', async () => {
const props = {
itemId: 3,
fetchFaveStar: jest.fn(),
@@ -84,7 +84,10 @@ test('Call fetchFaveStar only on the first render', () => {
showTooltip: false,
};
- const { rerender } = render(<FaveStar {...props} />);
+ const { rerender, findByRole } = render(<FaveStar {...props} />);
+ expect(
+ await findByRole('img', { name: 'favorite-unselected' }),
+ ).toBeInTheDocument();
expect(props.fetchFaveStar).toBeCalledTimes(1);
expect(props.fetchFaveStar).toBeCalledWith(props.itemId);