[GitHub] merlimat commented on issue #2210: PulsarSpout to use consumer.redeliverUnacknowledgedMessages() ?

[GitBox <gi...@apache.org>]

merlimat commented on issue #2210: PulsarSpout to use consumer.redeliverUnacknowledgedMessages() ?
URL: https://github.com/apache/incubator-pulsar/issues/2210#issuecomment-407477132
 
 
   @jnioche Yes, that makes total sense. The only reason for this to not use `redeliverUnacknowledgedMessages()` in the spout was that the method didn't exist when we added the spout :).
   
   Probably it would even be better to use the method at #2211 so that we can precisely control the redelivery.
   
   
   > Should we add consumer.redeliverUnacknowledgedMessages() to the initialisation of the spout? 
   
   When subscribing the unacked messages are automatically re-delivered. The only downside of `redeliverUnacknowledgedMessages()` would be that it triggers the re-delivery of unacked messages.
   
   The most complicated part in the PulsarSpout is the caching of client and consumer instances. This was done to shared resources across threads when users set high parallelism in the topologies.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services