You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/20 11:57:34 UTC
[PR] upgrade r2dbc libs (1.0) [incubator-pekko-persistence-r2dbc]
pjfanning opened a new pull request, #89:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/89
relates to #40
newer r2dbc libs bring in newer netty libs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#discussion_r1536606368
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Flux
.from[Result](stmt.execute())
.concatMap(_.getRowsUpdated)
- .collect(() => 0, consumer)
+ .collect(() => 0L, consumer)
.asFuture()
+ .map(_.intValue())
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [incubator-pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #89:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/89#discussion_r1531965744
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Flux
.from[Result](stmt.execute())
.concatMap(_.getRowsUpdated)
- .collect(() => 0, consumer)
+ .collect(() => 0L, consumer)
.asFuture()
+ .map(_.intValue())
Review Comment:
raised https://github.com/apache/incubator-pekko-persistence-r2dbc/issues/90 for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#discussion_r1536605923
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Flux
.from[Result](stmt.execute())
.concatMap(_.getRowsUpdated)
- .collect(() => 0, consumer)
+ .collect(() => 0L, consumer)
.asFuture()
+ .map(_.intValue())
Review Comment:
map(_.intvalue)(ExecutionContexts.parasitic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#discussion_r1536605127
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Review Comment:
there is a ObjLongConsumer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#discussion_r1536605923
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Flux
.from[Result](stmt.execute())
.concatMap(_.getRowsUpdated)
- .collect(() => 0, consumer)
+ .collect(() => 0L, consumer)
.asFuture()
+ .map(_.intValue())
Review Comment:
map(_.intvalue)(ExecutionContexts.parasitic)
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Flux
.from[Result](stmt.execute())
.concatMap(_.getRowsUpdated)
- .collect(() => 0, consumer)
+ .collect(() => 0L, consumer)
.asFuture()
+ .map(_.intValue())
Review Comment:
map(_.intvalue)(ExecutionContexts.parasitic)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#issuecomment-2016427167
We have branched 1.0.x so this is safe to merge to main. Would anyone have time to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [incubator-pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #89:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/89#discussion_r1531988010
##########
project/Dependencies.scala:
##########
@@ -32,17 +32,10 @@ object Dependencies {
val pekkoProjectionCore = "org.apache.pekko" %% "pekko-projection-core" % PekkoProjectionVersion
- val r2dbcSpi = "io.r2dbc" % "r2dbc-spi" % "0.9.1.RELEASE"
- val r2dbcPool = "io.r2dbc" % "r2dbc-pool" % "0.9.2.RELEASE"
-
- // This is here because sbt's ivy resolver doesn't properly support packaging.type when
- // resolving via sbt-license-report, see https://github.com/sbt/sbt-license-report/issues/87
+ val r2dbcSpi = "io.r2dbc" % "r2dbc-spi" % "1.0.0.RELEASE"
+ val r2dbcPool = "io.r2dbc" % "r2dbc-pool" % "1.0.1.RELEASE"
val r2dbcPostgres = Seq(
- ("org.postgresql" % "r2dbc-postgresql" % "0.9.3.RELEASE").excludeAll(
- "io.netty.incubator", "netty-incubator-codec-native-quic"),
- ("io.netty.incubator" % "netty-incubator-codec-native-quic" % "0.0.33.Final")
- .artifacts(Artifact("netty-incubator-codec-native-quic",
- url("https://repo1.maven.org/maven2/io/netty/incubator/netty-incubator-codec-native-quic/0.0.33.Final/netty-incubator-codec-native-quic-0.0.33.Final.jar"))))
Review Comment:
this jar no longer seems to be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade r2dbc libs (1.0) [pekko-persistence-r2dbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #89:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/89#discussion_r1536605127
##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/internal/R2dbcExecutor.scala:
##########
@@ -58,12 +58,13 @@ import reactor.core.publisher.Mono
}
def updateBatchInTx(stmt: Statement)(implicit ec: ExecutionContext): Future[Int] = {
- val consumer: BiConsumer[Int, Integer] = (acc, elem) => acc + elem.intValue()
+ val consumer: BiConsumer[Long, java.lang.Long] = (acc, elem) => acc + elem.intValue()
Review Comment:
there is a ObjLongConsumer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org