You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/07 20:53:15 UTC
[GitHub] [nifi] mcgilman opened a new pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
mcgilman opened a new pull request #5371:
URL: https://github.com/apache/nifi/pull/5371
NIFI-8491:
- Adding support for configuring parameter context inheritance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman merged pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mcgilman merged pull request #5371:
URL: https://github.com/apache/nifi/pull/5371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-930207949
@mtien-apache Thanks for reviewing! Good catch on the text clipping and the pending message. Will address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-914624509
I still have a couple of things to close out before this PR is ready for review and merging. However, I'm opening it in its current state to more easily integrate with new endpoints supporting this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-919621384
Reviewing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman merged pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mcgilman merged pull request #5371:
URL: https://github.com/apache/nifi/pull/5371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mcgilman commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-930207949
@mtien-apache Thanks for reviewing! Good catch on the text clipping and the pending message. Will address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mtien-apache commented on pull request #5371: NIFI-8491: Adding support for configuring parameter context inheritance
Posted by GitBox <gi...@apache.org>.
mtien-apache commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-920103606
Nice work, @mcgilman! I was able to successfully build on openjdk version 1.8.0_282. So far, the UI runs well. I'm able to create parameter contexts, add and remove the desired inherited order to use.
One error I noticed in the CI build were some frontend linting errors. After you're able to fix these, I will be happy to review again. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org