You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/27 12:00:05 UTC

[GitHub] [airflow] subkanthi commented on a change in pull request #17253: add encoding config in FtpHook

subkanthi commented on a change in pull request #17253:
URL: https://github.com/apache/airflow/pull/17253#discussion_r677379966



##########
File path: airflow/providers/ftp/hooks/ftp.py
##########
@@ -60,8 +60,10 @@ def get_conn(self) -> ftplib.FTP:
         if self.conn is None:
             params = self.get_connection(self.ftp_conn_id)
             pasv = params.extra_dejson.get("passive", True)
+            encoding = params.extra_dejson.get("encoding", "latin-1")

Review comment:
       is there a reason this defaults to latin-1 and not utf-8?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org