You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2015/11/06 15:17:20 UTC
Review Request 40020: Inappropriate scaling in query history "filter
by duration"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40020/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13766
https://issues.apache.org/jira/browse/AMBARI-13766
Repository: ambari
Description
-------
Introduce a util function secondsToHHMMSS for converting time in seconds to HH MM SS.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js 80489dc
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/number-range-widget.hbs 279ec07
contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js 73dbc8c
Diff: https://reviews.apache.org/r/40020/diff/
Testing
-------
mvn clean install
Here are the build results.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.355 sec
Running org.apache.ambari.view.hive.client.ConnectionTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.278 sec
Running org.apache.ambari.view.hive.PropertyValidatorTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.464 sec
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.166 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec
Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.667 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.662 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.445 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.101 sec
Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.03 sec
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 sec
Results :
Tests run: 54, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: .git/
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.gitattributes
[INFO] Exclude: .idea/
[INFO] Exclude: pass.txt
[INFO] Exclude: .DS_Store
[INFO] Exclude: .iml/
[INFO] Exclude: .classpath
[INFO] Exclude: .project
[INFO] Exclude: .settings
[INFO] Exclude: **/target/**
[INFO] Exclude: **/.gitkeep
[INFO] Exclude: **/.bowerrc
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.jshintrc
[INFO] Exclude: **/.tmp/**
[INFO] Exclude: **/tmp/**
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/bin
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/vendor/**
[INFO] Exclude: **/public/**
[INFO] Exclude: **/dist/**
[INFO] Exclude: **/bower_components/**
[INFO] Exclude: **/bower/**
[INFO] Exclude: **/node/**
[INFO] Exclude: **/runner.js
[INFO] Exclude: **/assets/javascripts/**
[INFO] Exclude: **/assets/stylesheets/**
[INFO] Exclude: **/assets/static/javascripts/**
[INFO] Exclude: **/assets/static/stylesheets/**
[INFO] Exclude: storm/src/main/resources/**
[INFO] 322 resources included (use -debug for more details)
Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
Compiler warnings:
WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 321 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
[INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
[INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @ hive ---
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.039s
[INFO] Finished at: Fri Nov 06 19:45:31 IST 2015
[INFO] Final Memory: 56M/914M
[INFO] ------------------------------------------------------------------------
Thanks,
Pallav Kulshreshtha
Re: Review Request 40020: Inappropriate scaling in query history
"filter by duration"
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40020/#review105536
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Nov. 6, 2015, 2:17 p.m., Pallav Kulshreshtha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40020/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 2:17 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13766
> https://issues.apache.org/jira/browse/AMBARI-13766
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Introduce a util function secondsToHHMMSS for converting time in seconds to HH MM SS.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js 80489dc
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/number-range-widget.hbs 279ec07
> contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js 73dbc8c
>
> Diff: https://reviews.apache.org/r/40020/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> Here are the build results.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.355 sec
> Running org.apache.ambari.view.hive.client.ConnectionTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.278 sec
> Running org.apache.ambari.view.hive.PropertyValidatorTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.464 sec
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.166 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobLDAPServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.667 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.662 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.445 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryResourceManagerTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.101 sec
> Running org.apache.ambari.view.hive.resources.savedQueries.SavedQueryServiceTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.03 sec
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 sec
>
> Results :
>
> Tests run: 54, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO]
> [INFO] --- apache-rat-plugin:0.11:check (default) @ hive ---
> [INFO] 51 implicit excludes (use -debug for more details).
> [INFO] Exclude: .git/
> [INFO] Exclude: **/.gitignore
> [INFO] Exclude: **/.gitattributes
> [INFO] Exclude: .idea/
> [INFO] Exclude: pass.txt
> [INFO] Exclude: .DS_Store
> [INFO] Exclude: .iml/
> [INFO] Exclude: .classpath
> [INFO] Exclude: .project
> [INFO] Exclude: .settings
> [INFO] Exclude: **/target/**
> [INFO] Exclude: **/.gitkeep
> [INFO] Exclude: **/.bowerrc
> [INFO] Exclude: **/.editorconfig
> [INFO] Exclude: **/.jshintrc
> [INFO] Exclude: **/.tmp/**
> [INFO] Exclude: **/tmp/**
> [INFO] Exclude: **/*.json
> [INFO] Exclude: **/*.svg
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/bin
> [INFO] Exclude: **/node_modules/**
> [INFO] Exclude: **/vendor/**
> [INFO] Exclude: **/public/**
> [INFO] Exclude: **/dist/**
> [INFO] Exclude: **/bower_components/**
> [INFO] Exclude: **/bower/**
> [INFO] Exclude: **/node/**
> [INFO] Exclude: **/runner.js
> [INFO] Exclude: **/assets/javascripts/**
> [INFO] Exclude: **/assets/stylesheets/**
> [INFO] Exclude: **/assets/static/javascripts/**
> [INFO] Exclude: **/assets/static/stylesheets/**
> [INFO] Exclude: storm/src/main/resources/**
> [INFO] 322 resources included (use -debug for more details)
> Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> Compiler warnings:
> WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.'
> Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.
> Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized.
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 321 licence.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ hive ---
> [INFO] Building jar: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ hive ---
> [INFO] Reading assembly descriptor: /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/ambari-project/src/main/assemblies/empty.xml
> [INFO]
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive ---
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/target/hive-1.0.0.0.0-SNAPSHOT.jar to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.jar
> [INFO] Installing /Users/pkulshreshtha/build_Aug01/ambari-vagrant/centos6.4/development/ambari/contrib/views/hive/pom.xml to /Users/pkulshreshtha/.m2/repository/org/apache/ambari/contrib/views/hive/1.0.0.0.0-SNAPSHOT/hive-1.0.0.0.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38.039s
> [INFO] Finished at: Fri Nov 06 19:45:31 IST 2015
> [INFO] Final Memory: 56M/914M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Pallav Kulshreshtha
>
>