You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/12/21 11:26:09 UTC

[GitHub] tinkerpop issue #518: Honor the equals() contract on Property impls by allow...

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/518
  
    hmmm - i'm not sure why `ElementHelper.areEqual(Property, Object)` needs to throw exceptions for null situations. i'm not so sure that's really how it should work. In studying some of the usage, I don't see where that's really valuable logic. I think the better fix is to just to make `ElementHelper.areEqual(Property, Object)` handle nulls properly like the other `areEqual()` methods.  @okram any problems taking that approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---