You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/06 13:40:30 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12133: Fix
#12076
susiwen8 opened a new pull request #12133: Fix #12076
URL: https://github.com/apache/incubator-echarts/pull/12133
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Legend color follow item color
### Fixed issues
#12076
## Details
### Before: What was the problem?
<img width="566" alt="Screen Shot 2020-02-06 at 21 38 11" src="https://user-images.githubusercontent.com/20318608/73941969-2ca94900-4929-11ea-808e-0440becf5825.png">
### After: How is it fixed in this PR?
<img width="620" alt="Screen Shot 2020-02-06 at 21 13 07" src="https://user-images.githubusercontent.com/20318608/73942005-3d59bf00-4929-11ea-9e17-fed2d8bdebad.png">
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12133: Fix
#12076
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12133: Fix #12076
URL: https://github.com/apache/incubator-echarts/pull/12133#issuecomment-582910171
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12133: Fix #12076
Legend color follow item color
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12133: Fix #12076 Legend color follow item color
URL: https://github.com/apache/incubator-echarts/pull/12133#issuecomment-592314916
Should the legend line in your case be green? I think this would be more intuitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on issue #12133: Fix #12076
Legend color follow item color
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on issue #12133: Fix #12076 Legend color follow item color
URL: https://github.com/apache/incubator-echarts/pull/12133#issuecomment-592911865
@Ovilia I have the same concern, but legend color took from connected dot, in this case it was blue. If we want to enhance this, make legend color more accurate, the line should be green and circle should be blue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 closed pull request #12133: Fix #12076 Legend color follow item color
Posted by GitBox <gi...@apache.org>.
susiwen8 closed pull request #12133:
URL: https://github.com/apache/incubator-echarts/pull/12133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org