You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/14 17:01:49 UTC

[GitHub] [hudi] xiarixiaoyao commented on a diff in pull request #5572: [HUDI-3654] Preparations for hudi metastore.

xiarixiaoyao commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r873052612


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -165,6 +167,11 @@ private static HoodieTableFileSystemView createInMemoryFileSystemView(HoodieMeta
       return new HoodieMetadataFileSystemView(metaClient, metaClient.getActiveTimeline().filterCompletedAndCompactionInstants(),
           metadataSupplier.get());
     }
+    if (metaClient.getMetastoreConfig().enableMetastore()) {
+      return (HoodieTableFileSystemView) ReflectionUtils.loadClass("org.apache.hudi.common.table.view.HoodieMetastoreFileSystemView",

Review Comment:
   Please define the “org.xxxx.View” as a static final constant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org