[GitHub] himanshug commented on a change in pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup
URL: https://github.com/apache/incubator-druid/pull/6207#discussion_r212120761
 
 

 ##########
 File path: extensions-core/kafka-indexing-service/src/test/java/io/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java
 ##########
 @@ -2115,12 +2115,8 @@ public void testCheckpointForInactiveTaskGroup()
 
     verifyAll();
 
-    while (serviceEmitter.getStackTrace() != null) {
-      Thread.sleep(100);
-    }
-
-    Assert.assertNull(serviceEmitter.getStackTrace());
-    Assert.assertNull(serviceEmitter.getExceptionMessage());
+    Assert.assertNull(serviceEmitter.getStackTrace(), serviceEmitter.getStackTrace());
 
 Review comment:
   is this a fix or just temp debugging arrangement to see what is in the stacktrace so that later a fix can be done ?
   
   test times out because serviceEmitter.getStackTrace() is non-null , so this assertion is gonna fail in those cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org