You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/04/11 10:47:34 UTC
Re: svn commit: r14098 - in trunk: . subversion/libsvn_client subversion/tests/clients/cmdline
jszakmeister@tigris.org wrote:
> Author: jszakmeister
> Date: Mon Apr 11 05:08:14 2005
> New Revision: 14098
>
> Added:
> trunk/subversion/tests/clients/cmdline/cat_tests.py (contents, props
> changed)
> Modified:
> trunk/build.conf
> trunk/subversion/libsvn_client/cat.c
> Log:
> Fix a segfault when running 'svn cat' on a nonexistant file. Add some new
> tests to catch these sort of errors in the future.
>
> Thanks to julianfoad and philip for pointing these out.
>
> * build.conf [M.]
> (test-scripts): Added cat_tests.py to the test script list.
>
> * subversion/libsvn_client/cat.c [M.]
> (cat_local_file): Add a short description of the function. Error out on
> a
> NULL entry.
>
> (svn_client_cat2): Optimize a bit and use svn_wc_adm_open3() on the
> dirname
> of the path, since we expect it to point to a file.
>
> * subversion/tests/clients/cmdline/cat_tests.py [A.]
> New.
Why the curious logmessage style ([M.], etc.) ?
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r14098 - in trunk: . subversion/libsvn_client subversion/tests/clients/cmdline
Posted by John Szakmeister <jo...@szakmeister.net>.
On Monday 11 April 2005 06:47, Max Bowsher wrote:
> jszakmeister@tigris.org wrote:
> > Author: jszakmeister
> > Date: Mon Apr 11 05:08:14 2005
> > New Revision: 14098
> >
> > Added:
> > trunk/subversion/tests/clients/cmdline/cat_tests.py (contents,
> > props changed)
> > Modified:
> > trunk/build.conf
> > trunk/subversion/libsvn_client/cat.c
> > Log:
> > Fix a segfault when running 'svn cat' on a nonexistant file. Add
> > some new tests to catch these sort of errors in the future.
> >
> > Thanks to julianfoad and philip for pointing these out.
> >
> > * build.conf [M.]
> > (test-scripts): Added cat_tests.py to the test script list.
> >
> > * subversion/libsvn_client/cat.c [M.]
> > (cat_local_file): Add a short description of the function. Error
> > out on a
> > NULL entry.
> >
> > (svn_client_cat2): Optimize a bit and use svn_wc_adm_open3() on the
> > dirname
> > of the path, since we expect it to point to a file.
> >
> > * subversion/tests/clients/cmdline/cat_tests.py [A.]
> > New.
>
> Why the curious logmessage style ([M.], etc.) ?
Doh! It's part of a script that I have to build a log message template
for other projects I have at work. I yank the first two bytes of the
status output and put them at the end of the path. It's a little easier
to tell what's going on. :-) I just forgot to fix them before
committing. It should be taken care of now. Thanks!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org