You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Nicolas FOATA <ni...@gmail.com> on 2013/08/02 13:56:40 UTC
Review Request 13238: JIRA-3701 : VM instantiation : Sending network
information to a new VM instance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Abstract/suggestion:
While a VM is instantiated, CloudStack could also send the following information if need be :
- the instance name (CS uuid)
- the display name
- VM tags
- network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
just if we activate some global settings such as :
- vm.instance.boot.network.required (true/false)
- vm.instance.boot.vmname (true/false)
- vm.instance.boot.uuid (true/false)
- vm.instance.boot.tags (true/false)
Applications:
- A VM could discover its network and dialog with physical and virtual machines, etc.
- A VM do not need a virtual router
- According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42
server/src/com/cloud/configuration/Config.java c815c77
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
Diff: https://reviews.apache.org/r/13238/diff/
Testing
-------
Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / => - _)
Thanks,
Nicolas FOATA
Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network
information to a new VM instance
Posted by Amogh Vasekar <am...@citrix.com>.
> On Aug. 2, 2013, 12:17 p.m., Jenkins Cloudstack.org wrote:
> > Review 13238 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #108 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/108/
Reminder -
Hi,
This request has been pending for long. Please take the time to address the comments raised. Thanks!
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/#review24526
-----------------------------------------------------------
On Oct. 1, 2013, 1:46 p.m., Nicolas FOATA wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13238/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chiradeep Vittal.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Abstract/suggestion:
> While a VM is instantiated, CloudStack could also send the following information if need be :
> - the instance name (CS uuid)
> - the display name
> - VM tags
> - network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
> just if we activate some global settings such as :
> - vm.instance.boot.network.required (true/false)
> - vm.instance.boot.vmname (true/false)
> - vm.instance.boot.uuid (true/false)
> - vm.instance.boot.tags (true/false)
>
> Applications:
> - A VM could discover its network and dialog with physical and virtual machines, etc.
> - A VM do not need a virtual router
> - According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42
> server/src/com/cloud/configuration/Config.java c815c77
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
>
> Diff: https://reviews.apache.org/r/13238/diff/
>
>
> Testing
> -------
>
> Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / => - _)
>
>
> Thanks,
>
> Nicolas FOATA
>
>
Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network
information to a new VM instance
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/#review24526
-----------------------------------------------------------
Review 13238 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #108 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/108/
- Jenkins Cloudstack.org
On Aug. 2, 2013, 11:56 a.m., Nicolas FOATA wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13238/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 11:56 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Abstract/suggestion:
> While a VM is instantiated, CloudStack could also send the following information if need be :
> - the instance name (CS uuid)
> - the display name
> - VM tags
> - network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
> just if we activate some global settings such as :
> - vm.instance.boot.network.required (true/false)
> - vm.instance.boot.vmname (true/false)
> - vm.instance.boot.uuid (true/false)
> - vm.instance.boot.tags (true/false)
>
> Applications:
> - A VM could discover its network and dialog with physical and virtual machines, etc.
> - A VM do not need a virtual router
> - According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42
> server/src/com/cloud/configuration/Config.java c815c77
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
>
> Diff: https://reviews.apache.org/r/13238/diff/
>
>
> Testing
> -------
>
> Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / => - _)
>
>
> Thanks,
>
> Nicolas FOATA
>
>
Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network
information to a new VM instance
Posted by Nicolas FOATA <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 1:46 p.m.)
Review request for cloudstack and Chiradeep Vittal.
Repository: cloudstack-git
Description
-------
Abstract/suggestion:
While a VM is instantiated, CloudStack could also send the following information if need be :
- the instance name (CS uuid)
- the display name
- VM tags
- network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
just if we activate some global settings such as :
- vm.instance.boot.network.required (true/false)
- vm.instance.boot.vmname (true/false)
- vm.instance.boot.uuid (true/false)
- vm.instance.boot.tags (true/false)
Applications:
- A VM could discover its network and dialog with physical and virtual machines, etc.
- A VM do not need a virtual router
- According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42
server/src/com/cloud/configuration/Config.java c815c77
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
Diff: https://reviews.apache.org/r/13238/diff/
Testing
-------
Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / => - _)
Thanks,
Nicolas FOATA
Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network
information to a new VM instance
Posted by Nicolas FOATA <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13238/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 1:46 p.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
Abstract/suggestion:
While a VM is instantiated, CloudStack could also send the following information if need be :
- the instance name (CS uuid)
- the display name
- VM tags
- network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.)
just if we activate some global settings such as :
- vm.instance.boot.network.required (true/false)
- vm.instance.boot.vmname (true/false)
- vm.instance.boot.uuid (true/false)
- vm.instance.boot.tags (true/false)
Applications:
- A VM could discover its network and dialog with physical and virtual machines, etc.
- A VM do not need a virtual router
- According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42
server/src/com/cloud/configuration/Config.java c815c77
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
Diff: https://reviews.apache.org/r/13238/diff/
Testing
-------
Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / => - _)
Thanks,
Nicolas FOATA