You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/25 17:36:13 UTC
[GitHub] [airflow] mcreenan opened a new pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
mcreenan opened a new pull request #17210:
URL: https://github.com/apache/airflow/pull/17210
closes: #16972
This change ensures the role session name only contains valid characters according to the pattern defined by the RoleSessionName parameter in STS AssumeRole (https://docs.aws.amazon.com/STS/latest/APIReference/API_AssumeRole.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886262026
Now - we are back to "real" issues - static checks are failing - there are some CHANGELOG,rst entries wrong (single instead of double backticks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17210:
URL: https://github.com/apache/airflow/pull/17210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17210:
URL: https://github.com/apache/airflow/pull/17210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886256394
Rebuilding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcreenan commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
mcreenan commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886267480
>
>
> Now - we are back to "real" issues - static checks are failing - there are some CHANGELOG,rst entries wrong (single instead of double backticks)
Can you help me understand what's going on here? I didn't change CHANGELOG.rst.
>
>
> And some unit tests
I'll look at those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-890597748
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcreenan commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
mcreenan commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886260543
>
>
> Can you please rebase to latest main @mcreenan - I think I fixed all the "red-build" stability issues that plagued us in the last week
Done... I think. I'm new to this style of workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886260860
Yeah. Airflow is a beast and keeping it tamed is a special kinda skill. Sometimes it shows it's humours :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcreenan commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
mcreenan commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886276143
There's something strange going on. The tests that are failing aren't at all related to what I changed (especially the google ones). When I run the aws providers tests locally, I get 2 other unrelated errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcreenan commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
mcreenan commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-887112931
>
>
> Please rebase to latest `main` - we had some problems with `main` broken. Those problem should be fixed now.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886263447
And some unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886260294
Can you please rebase to latest main @mcreenan - I think I fixed all the "red-build" stability issues that plagued us in the last week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mcreenan commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
mcreenan commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-889183860
Is there anything else I need to do with this PR? It looks like the latest run of tests still had some failures unrelated to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886234376
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886594099
Please rebase to latest `main` - we had some problems with `main` broken. Those problem should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17210: Fixes #16972 - Slugify role session name in AWS base hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17210:
URL: https://github.com/apache/airflow/pull/17210#issuecomment-886241449
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org