[GitHub] [storm] srdo commented on a change in pull request #2878: [STORM-3257] 'storm kill' command line should be able to continue on error

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #2878: [STORM-3257] 'storm kill' command line should be able to continue on error
URL: https://github.com/apache/storm/pull/2878#discussion_r309601505
 
 

 ##########
 File path: storm-core/src/jvm/org/apache/storm/command/KillTopology.java
 ##########
 @@ -25,21 +25,49 @@
 
     public static void main(String[] args) throws Exception {
         Map<String, Object> cl = CLI.opt("w", "wait", null, CLI.AS_INT)
+                                    .boolOpt("i", "ignore-errors")
 
 Review comment:
   I'm not sure how people could be depending on the old behavior, but sure it probably doesn't hurt to make this optional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services