You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/07 16:37:30 UTC

[GitHub] [iotdb] DittoTool commented on pull request #3926: Inefficient Usage of JCF

DittoTool commented on pull request #3926:
URL: https://github.com/apache/iotdb/pull/3926#issuecomment-914457304


   I appended several other transformations just now, in which a list used for ownership checking is transformed to HashSet. I think these transformations are meaningful both in the theoretical and practical manner. Besides, here is another case as follows. https://github.com/apache/iotdb/blob/860c8de52ced88b4440f10bc0b07cd8a9c7441bd/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBDatabaseMetadata.java#L1395-L1397
   I did not include it and submit the transformation for it because the size of the list is only 4. However, I still think it would be better if a set is constructed to maintain the four elements rather than list during the initialization.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org