You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "veriiix (via GitHub)" <gi...@apache.org> on 2026/10/04 13:52:04 UTC
[PR] fix(explore): preserve zero thresholds in contour controls [superset]
veriiix opened a new pull request, #44966:
URL: https://github.com/apache/superset/pull/44966
### SUMMARY
Treat 0 as a valid contour threshold. Keep zero-bound isobands on the correct tab, show zero in inputs and labels, and validate threshold ordering.
Fixes #44913.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: zero thresholds appeared empty or caused an isoband to appear as an isoline.
After: zero thresholds display correctly and retain the correct contour type.
### TESTING INSTRUCTIONS
Tested the patched components in a local Storybook preview:
- Save and reopen [-1, 0] and [0, 1]: remain isobands with zero visible.
- Enter [0, 0], [0, -1], or [1, 0]: ordering errors appear and Save is disabled.
- Save an isoline with threshold 0: label shows 0 and Isoline stays selected.
- Clear a required threshold: Save is disabled.
- Formatting and git diff --check pass.
- Lint reports 0 errors and 2 warnings in unchanged code.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #44913
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4180219930
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
โ
**CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `9fbc8bf`.
The popover now determines the active tab with `isIsoband`, which checks whether both thresholds are present, including zero. `getTabKey` uses that same check to select the isoband tab.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4334565591
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
โ
**CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `9212a71`.
`getTabKey` now selects the isoband tab using `isIsoband(contour)`, which checks for both thresholds and recognizes zero as a valid value.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4330485151
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
โ
**CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `2261682`.
The popover now determines the active tab with `isIsoband`, which checks whether both thresholds are present, including zero. `getTabKey` uses that same check to select the isoband tab.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4177964259
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourOption.tsx:
##########
@@ -49,7 +49,7 @@ const ContourOption = ({
}: ContourOptionProps) => {
const { lowerThreshold, upperThreshold, color, strokeWidth } = contour;
- const isIsoband = upperThreshold;
+ const isIsoband = Boolean(upperThreshold) || upperThreshold === 0;
Review Comment:
**Suggestion:** `upperThreshold: 0` is now displayed and saved as an isoband, but the DeckGL renderer still treats zero as an isoline, losing the threshold range.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fb0c988ce3d2409b9869a02d270bf4c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fb0c988ce3d2409b9869a02d270bf4c7&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/controls/ContourControl/ContourOption.tsx
**Line:** 52:52
**Comment:**
*Api Mismatch: `upperThreshold: 0` is now displayed and saved as an isoband, but the DeckGL renderer still treats zero as an isoline, losing the threshold range.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=1239b1b78e11673bd1ff51afe6e0b79a45ed894896c5e04dea1e28e689cc309a&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=1239b1b78e11673bd1ff51afe6e0b79a45ed894896c5e04dea1e28e689cc309a&reaction=dislike'>๐</a>
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
**Suggestion:** A contour with both thresholds but fewer than four enumerable fields is shown as an isoband here but opens in the isoline tab, disagreeing with its displayed option.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7f6604e8c2d94102ad02948e04879565&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7f6604e8c2d94102ad02948e04879565&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx
**Line:** 53:56
**Comment:**
*Api Mismatch: A contour with both thresholds but fewer than four enumerable fields is shown as an isoband here but opens in the isoline tab, disagreeing with its displayed option.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=8a2c2f0a9ccbe81df08c027f2961ca68f089c87fb9df7cfb0e1ff356a0881d82&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44966&comment_hash=8a2c2f0a9ccbe81df08c027f2961ca68f089c87fb9df7cfb0e1ff356a0881d82&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4332852909
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
โ
**CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `e234f6f`.
`getTabKey` now selects the isoband tab using `isIsoband(contour)`, which checks for both thresholds and recognizes zero as a valid value.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-6301819155
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; the renderer recognizes a zero upper threshold, and the editor and tab selection consistently require both thresholds for an isoband.
**Assessed commit:** `226168241e0d`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44966:
URL: https://github.com/apache/superset/pull/44966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-5980719155
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4178800500
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -50,7 +50,10 @@ const isIsoband = (contour: ContourType) => {
if (Object.keys(contour).length < 4) {
return false;
}
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
+ (contour.upperThreshold || contour.upperThreshold === 0) &&
+ (contour.lowerThreshold || contour.lowerThreshold === 0)
+ );
Review Comment:
โ
**CodeAnt verified this suggestion was addressed in subsequent commits and marked this thread resolved** as of `89f27dc`.
The tab selection now uses the same threshold-presence check as the isoband display: both `lowerThreshold` and `upperThreshold` may be zero and must be present for the Isoband tab.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-5981005041
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44966?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `20.00000%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.28%. Comparing base ([`ccae778`](https://app.codecov.io/gh/apache/superset/commit/ccae77849824db1fb3bc8c0107b6fb109fbb31c4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb28f24`](https://app.codecov.io/gh/apache/superset/commit/bb28f24f656b6d6e98a1f82da460af189270ef27?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44966?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../controls/ContourControl/ContourPopoverControl.tsx](https://app.codecov.io/gh/apache/superset/pull/44966?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fexplore%2Fcomponents%2Fcontrols%2FContourControl%2FContourPopoverControl.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db250b3VyQ29udHJvbC9Db250b3VyUG9wb3ZlckNvbnRyb2wudHN4) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44966?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mponents/controls/ContourControl/ContourOption.tsx](https://app.codecov.io/gh/apache/superset/pull/44966?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fexplore%2Fcomponents%2Fcontrols%2FContourControl%2FContourOption.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db250b3VyQ29udHJvbC9Db250b3VyT3B0aW9uLnRzeA==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44966?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44966 +/- ##
==========================================
- Coverage 82.28% 82.28% -0.01%
==========================================
Files 2997 2997
Lines 185240 185242 +2
Branches 42867 42869 +2
==========================================
+ Hits 152433 152434 +1
- Misses 30045 30046 +1
Partials 2762 2762
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44966/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44966/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.90% <20.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44966?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-5988466305
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-5984597430
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44966:
URL: https://github.com/apache/superset/pull/44966#issuecomment-6307598045
### <span aria-hidden="true">โ
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">๐จ</span> Latest commit | e234f6f6564e93d15b6ed75cb803720868235626 |
|<span aria-hidden="true">๐</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ad836563ac3aa9a1755d345 |
|<span aria-hidden="true">๐</span> Deploy Preview | [https://deploy-preview-44966--superset-docs-preview.netlify.app](https://deploy-preview-44966--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">๐ฑ</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">๐ค</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpJDoAgDADAv_QsB4Pg8gOfUSkGE6SkYuIS_y63OcwLWXjPBSaABhbB5EL1ul3KcSp8inq8sCpB_BE40lEb-Rz5nqlGizRoa6xGpxFHbHtjSHcGvh8) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44966--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): preserve zero thresholds in contour controls [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44966:
URL: https://github.com/apache/superset/pull/44966#discussion_r4330776924
##########
superset-frontend/src/explore/components/controls/ContourControl/ContourPopoverControl.tsx:
##########
@@ -47,10 +47,10 @@ const StyledRow = styled(Row)`
`;
const isIsoband = (contour: ContourType) => {
- if (Object.keys(contour).length < 4) {
- return false;
- }
- return contour.upperThreshold && contour.lowerThreshold;
+ return (
Review Comment:
With the early return gone, `isIsoband` is now a block body containing only `return (...)`, which the repo's oxlint `arrow-body-style` rule rewrites to an expression body. The pre-commit job runs with `--fix`, so it modifies this file and fails, which is what's turning the pre-commit check red on this head. Could you run the frontend lint/format hook locally and commit the autofix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org