You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/11/09 12:55:48 UTC
[Bug 8071] New: get_uri_detail_list & missing links
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Bug ID: 8071
Summary: get_uri_detail_list & missing links
Product: Spamassassin
Version: 3.4.6
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: pascal@halogen-consulting.com
Target Milestone: Undefined
there are links which are not identified when the html code contains tags like
that:
<!--[if mso]>
<!--[if !mso]><!-->
<!--[if gte mso 9]>
...
<!--<![endif]-->
<![endif]-->
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Benny Pedersen <me...@junc.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |me@junc.eu
--- Comment #11 from Benny Pedersen <me...@junc.eu> ---
its valid html5, with 418 warnings and 0 errors :)
if spamassassin had htmltidy, this would be pease of cake to get this info as
how valid spam or not spam is, imho we should not take the comment fails as
spammies, its a microsoft bug that should be fixed
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Pascal <pa...@halogen-consulting.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pascal@halogen-consulting.c
| |om
--- Comment #1 from Pascal <pa...@halogen-consulting.com> ---
my bugfix:
before using get_uri_detail_list, I remove these tags:
s/(?:<\!--)?<\!\[endif\]-->// for @lines;
s/<\!--\[if [\(\)\|\!\w\s]+\]>(?:<\!-->)?// for @lines;
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
John Hardin <jh...@impsec.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jhardin@impsec.org
--- Comment #2 from John Hardin <jh...@impsec.org> ---
Those are HTML comments, not links or tags, and they have no place in the uri
list.
If you want to see that content, use a rawbody rule.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |4.0.1
CC| |kmcgrail@apache.org
--- Comment #6 from Kevin A. McGrail <km...@apache.org> ---
I think we should look at this for 4.0.1 and consider if this is a dupe of bug
8024 as well
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
--- Comment #8 from Henrik Krohns <ap...@hege.li> ---
Agree for 4.0.1, needs some thought and proper testing to not break HTML stuff.
Maybe someone can also look if these are good spam indicators for rules.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
--- Comment #9 from Pascal <pa...@halogen-consulting.com> ---
Created attachment 5878
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5878&action=edit
impacted message
Here is a message for you to test.
It can't identify the jpg images using get_uri_detail_list function
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache@hege.li
--- Comment #4 from Henrik Krohns <ap...@hege.li> ---
(In reply to John Hardin from comment #2)
> Those are HTML comments, not links or tags, and they have no place in the
> uri list.
I think he's referring to this:
https://email2go.io/blog/outlook-conditional-code
Outlook will display anything inside those.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
--- Comment #3 from Pascal <pa...@halogen-consulting.com> ---
I mean that when there is an html code (containing links) inside comment tags,
the function does not identify the links.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.0.1 |Undefined
CC| |sidney@sidney.com
--- Comment #12 from Sidney Markowitz <si...@sidney.com> ---
Unless someone wants to argue with this being closed as WORKSFORME and reopen
it, it should not have a target milestone, so I'm changing that from 4.0.1 as
part of my 4.0.1 release cleanup.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
--- Comment #7 from Henrik Krohns <ap...@hege.li> ---
*** Bug 8024 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
--- Comment #5 from Pascal <pa...@halogen-consulting.com> ---
exactly
it will really be displayed on some email clients
It is probably the same than here:
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8024
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8071] get_uri_detail_list & missing links
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8071
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
CC| |giovanni@paclan.it
--- Comment #10 from Giovanni Bechis <gi...@paclan.it> ---
.jpg linked images on the provided spample are detected for me on trunk.
--
You are receiving this mail because:
You are the assignee for the bug.