You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2008/03/10 20:24:46 UTC

[jira] Created: (DERBY-3520) convert views.sql to junit

convert views.sql to junit
--------------------------

                 Key: DERBY-3520
                 URL: https://issues.apache.org/jira/browse/DERBY-3520
             Project: Derby
          Issue Type: Task
          Components: Test
    Affects Versions: 10.5.0.0
            Reporter: Kathey Marsden
            Assignee: Kathey Marsden
            Priority: Minor


With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (DERBY-3520) convert views.sql to junit

Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577832#action_12577832 ] 

johnemb edited comment on DERBY-3520 at 3/12/08 5:42 AM:
-------------------------------------------------------------------

The following committed code results in a Javadoc warning:

+     * @param sqlStates[]  expected sql state.
      * @param st Statement object on which to execute.
      * @param query the query to compile and execute.
      */
-    public static void assertStatementError(String sqlState,
+    public static void assertStatementError(String[] sqlStates,
         Statement st, String query)

/trunk/java/testing/org/apache/derbyTesting/junit/BaseJDBCTestCase.java:956: warning - @param argument "sqlStates[]" is not a parameter name.

      was (Author: johnemb):
    The folowing committed code results in a Javadoc warning:

+     * @param sqlStates[]  expected sql state.
      * @param st Statement object on which to execute.
      * @param query the query to compile and execute.
      */
-    public static void assertStatementError(String sqlState,
+    public static void assertStatementError(String[] sqlStates,
         Statement st, String query)

  
> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3520_diff.txt, derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3520) convert views.sql to junit

Posted by "John H. Embretsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577832#action_12577832 ] 

John H. Embretsen commented on DERBY-3520:
------------------------------------------

The folowing committed code results in a Javadoc warning:

+     * @param sqlStates[]  expected sql state.
      * @param st Statement object on which to execute.
      * @param query the query to compile and execute.
      */
-    public static void assertStatementError(String sqlState,
+    public static void assertStatementError(String[] sqlStates,
         Statement st, String query)


> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3520_diff.txt, derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3520) convert views.sql to junit

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden resolved DERBY-3520.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0
                   10.4.0.0
                   10.3.2.2

Actually fixed in  10.4.1.0, but we don't have a version for that yet in JIRA.



> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>             Fix For: 10.3.2.2, 10.4.0.0, 10.5.0.0
>
>         Attachments: derby-3520_diff.txt, derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3520) convert views.sql to junit

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden updated DERBY-3520:
----------------------------------

    Attachment: derby-3520_diff.txt

updated patch. forgot to delete views.sql and views.out


> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3520_diff.txt, derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3520) convert views.sql to junit

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden closed DERBY-3520.
---------------------------------


> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>             Fix For: 10.3.2.2, 10.4.0.0, 10.5.0.0
>
>         Attachments: derby-3520_diff.txt, derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3520) convert views.sql to junit

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden updated DERBY-3520:
----------------------------------

    Derby Info: [Patch Available]

derby-3520_diff.txt  patch available

> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3520) convert views.sql to junit

Posted by "Kathey Marsden (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kathey Marsden updated DERBY-3520:
----------------------------------

    Attachment: derby-3520_diff.txt

Attached is a patch for this issue.  I used the SQLToJUnit program to do most of the conversion.  I Addded a new method to BaseJDBCTestCase
   public static void assertStatementError(String[] sqlStates,
        Statement st, String query)
to allow for checking of multiple SQLStates.

I am running suites.All now.



> convert views.sql to junit
> --------------------------
>
>                 Key: DERBY-3520
>                 URL: https://issues.apache.org/jira/browse/DERBY-3520
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3520_diff.txt
>
>
> With the latest IBM 1.6 jvm I am seeing an ordering diff in the errors in drop table with views.sql so it would be good to convert to junit to avoid having separate jvm masters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.