[GitHub] [incubator-doris] imay commented on a change in pull request #1590: Implement BetaRowsetWriter

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1590: Implement BetaRowsetWriter
URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r311338710
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/segment_writer.cpp
 ##########
 @@ -30,7 +31,7 @@ const char* k_segment_magic = "D0R1";
 const uint32_t k_segment_magic_length = 4;
 
 SegmentWriter::SegmentWriter(std::string fname, uint32_t segment_id,
-                             const std::shared_ptr<TabletSchema>& tablet_schema,
 
 Review comment:
   should change unit-test for this class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org