You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/28 23:37:31 UTC

[GitHub] [incubator-superset] dwene opened a new issue #9225: No database role created when database is created.

dwene opened a new issue #9225: No database role created when database is created.
URL: https://github.com/apache/incubator-superset/issues/9225
 
 
   A clear and concise description of what the bug is.
   
   When a new database is created, there isn't a corresponding database role created.
   
   I've been trying to follow the docs for adding Gamma users here: https://superset.incubator.apache.org/security.html#sql-lab
   
   I'd like to create a Gamma user, give them sql lab rights, and give them access to a single database.
   When I add a database in the UI, and try to create a new role with privileges to query that database, there doesn't appear to be one.
   
   There is however a database role for the initially `examples` database. So it seems to me like there should be a database role for the other databases I added also.
   
   
   
   ### Expected results
   
   A new database role is created when I add a database
   
   ### Actual results
   
   No database role is created.
   
   #### Screenshots
   
   <img width="653" alt="Screen Shot 2020-02-28 at 5 32 00 PM" src="https://user-images.githubusercontent.com/12628251/75594998-636a0f00-5a50-11ea-8afb-ac68aef58150.png">
   <img width="649" alt="Screen Shot 2020-02-28 at 5 32 11 PM" src="https://user-images.githubusercontent.com/12628251/75594999-6402a580-5a50-11ea-9a8b-d1996670a62a.png">
   
   Notice how there is no database privilege for "dwene" but there is one for "example"
   
   #### How to reproduce the bug
   
   1. Go to Sources -> Databases.
   2. Add a new database.
   3. Go to roles.
   4. Try to create a new role with the new database privilege.
   5. Notice that there is no database privilege, only datasource and schema privileges.
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `0.35.2`
   - python version: whatever is in the built docker container.
   
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x ] I have reproduced the issue with at least the latest released version of superset.
   - [x ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dwene commented on issue #9225: No database privilege created when database is created.

Posted by GitBox <gi...@apache.org>.
dwene commented on issue #9225: No database privilege created when database is created.
URL: https://github.com/apache/incubator-superset/issues/9225#issuecomment-592854572
 
 
   Additional screenshot showing missing database_access privilege.
   I've added 2 other databases.
   
   ![image](https://user-images.githubusercontent.com/12628251/75600502-9ecb0480-5a75-11ea-877b-f62efcd993a6.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #9225: No database role created when database is created.

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9225: No database role created when database is created.
URL: https://github.com/apache/incubator-superset/issues/9225#issuecomment-592781256
 
 
   hey @dwene check out: https://github.com/apache/incubator-superset/pull/8699
   
   It may satisfy your requirements 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dwene commented on issue #9225: No database privilege created when database is created.

Posted by GitBox <gi...@apache.org>.
dwene commented on issue #9225: No database privilege created when database is created.
URL: https://github.com/apache/incubator-superset/issues/9225#issuecomment-592866539
 
 
   Interestingly enough, editing the database and saving (without making any changes) seems to resolve the problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dwene commented on issue #9225: No database privilege created when database is created.

Posted by GitBox <gi...@apache.org>.
dwene commented on issue #9225: No database privilege created when database is created.
URL: https://github.com/apache/incubator-superset/issues/9225#issuecomment-592850725
 
 
   Hey @nytai , thanks for responding. 
   
   The row based security is pretty cool! But not really what I'm looking for. I'm looking for a way to grant a user access to SQL lab for only 1 database. It seems like the way to do that is by making a new role with that database privilege (datasource and schema privileges don't appear to be enough), but I can't seem to find a way to add it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] stale[bot] commented on issue #9225: No database privilege created when database is created.

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9225:
URL: https://github.com/apache/incubator-superset/issues/9225#issuecomment-620983886


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org