You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/17 20:51:40 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #6163:
[AIRFLOW-4574] SSHHook private_key may only be supplied in extras
mik-laj commented on a change in pull request #6163: [AIRFLOW-4574] SSHHook private_key may only be supplied in extras
URL: https://github.com/apache/airflow/pull/6163#discussion_r336220904
##########
File path: tests/contrib/hooks/test_ssh_hook.py
##########
@@ -176,11 +212,13 @@ def test_tunnel(self):
import subprocess
import socket
- server_handle = subprocess.Popen(["python", "-c", HELLO_SERVER_CMD],
- stdout=subprocess.PIPE)
- with hook.create_tunnel(2135, 2134):
+ subprocess_kwargs = dict(
+ args=["python", "-c", HELLO_SERVER_CMD],
+ stdout=subprocess.PIPE,
+ )
+ with subprocess.Popen(**subprocess_kwargs) as server_handle, hook.create_tunnel(2135, 2134):
Review comment:
Nice!.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services