[GitHub] [druid] maytasm commented on a change in pull request #10891: Fix maxBytesInMemory for heap overhead of all sinks and hydrants check

[GitBox <gi...@apache.org>]

maytasm commented on a change in pull request #10891:
URL: https://github.com/apache/druid/pull/10891#discussion_r578944750



##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -332,6 +332,47 @@ public AppenderatorAddResult add(
       if (allowIncrementalPersists) {
         // persistAll clears rowsCurrentlyInMemory, no need to update it.
         log.info("Flushing in-memory data to disk because %s.", String.join(",", persistReasons));
+
+        long bytesPersisted = 0L;

Review comment:
       To avoid unnecessary cycle on Travis, I'm merging this in for now. However, I do agree that `bytesToBePersisted` is a better name for the variable. I'll sneak this change in some other PR since it's very small/trivial ;)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org