You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/09 09:17:00 UTC

[PR] fix(instance): preserve context on trailing-slash routes [rocketmq-dashboard]

Loyal-Young opened a new pull request, #5798:
URL: https://github.com/apache/rocketmq-dashboard/pull/5798

   ## What is the purpose of the change
   Fixes #5792. Match the trailing slashes that React Router accepts for instance resource routes, preserving both the selected instance and section.
   
   ## Brief changelog
   - Accept trailing slashes in scoped and static-section paths.
   - Cover encoded instance names in all five resource sections.
   - Check default-instance selection and unknown-instance recovery without changing sections.
   
   ## Verifying this change
   - Before the fix: 10 new route cases failed by redirecting to the first instance/topic page.
   - After the fix: all 14 useInstanceFilter tests passed.
   - TypeScript app check, changed-file ESLint, and git diff --check passed.
   - Full app build and backend tests were not rerun.
   
   ## AI assistance
   AI assisted with comparing the router paths with the filter parser, drafting MemoryRouter regressions and the parser correction, and reviewing the results.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): preserve context on trailing-slash routes [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #5798:
URL: https://github.com/apache/rocketmq-dashboard/pull/5798#issuecomment-6264571995

   Folded into #6703, merged into `rocketmq-studio` as 86aa49c34 — your change is in that commit and stays authored by you.
   
   We batched six related message-history / import / LiteTopic / settings PRs (#6703 #5790 #6705 #6721 #6711 #5798) into a single integration commit to keep the history readable, so this one is closed as folded rather than merged separately. No action needed; the linked issue is closed as resolved by #6703.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): preserve context on trailing-slash routes [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #5798: fix(instance): preserve context on trailing-slash routes
URL: https://github.com/apache/rocketmq-dashboard/pull/5798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): preserve context on trailing-slash routes [rocketmq-dashboard]

Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #5798:
URL: https://github.com/apache/rocketmq-dashboard/pull/5798#issuecomment-6261571509

   Progress update (2026-10-19):  GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org