You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Greg Mann (JIRA)" <ji...@apache.org> on 2016/03/30 02:29:25 UTC

[jira] [Comment Edited] (MESOS-5063) SSLTest.HTTPSPost and SSLTest.HTTPSGet tests fail

    [ https://issues.apache.org/jira/browse/MESOS-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217129#comment-15217129 ] 

Greg Mann edited comment on MESOS-5063 at 3/30/16 12:29 AM:
------------------------------------------------------------

The http-parser is throwing an error when parsing the responses defined [here|https://github.com/apache/mesos/blob/e79e690cc922ac407a46d6b4f914bf5709640fa1/3rdparty/libprocess/src/tests/ssl_tests.cpp#L655] and [here|https://github.com/apache/mesos/blob/e79e690cc922ac407a46d6b4f914bf5709640fa1/3rdparty/libprocess/src/tests/ssl_tests.cpp#L696].

It's giving the http-parser error code {{24}}, but I'm not sure which of [these errors|https://github.com/nodejs/http-parser/blob/master/http_parser.h#L159] that maps to. If they happen to be generate in their listed order, it would correspond to {{invalid character in header}}. If I edit the response headers that are defined at the links above, the error code will change, so it seems we may need to tweak these responses to play nicely with the new version of http-parser.


was (Author: greggomann):
The http-parser is throwing an error when parsing the responses defined [here|https://github.com/apache/mesos/blob/e79e690cc922ac407a46d6b4f914bf5709640fa1/3rdparty/libprocess/src/tests/ssl_tests.cpp#L655] and [here|https://github.com/apache/mesos/blob/e79e690cc922ac407a46d6b4f914bf5709640fa1/3rdparty/libprocess/src/tests/ssl_tests.cpp#L696].

It's giving the http-parser error code {{24}}, but I'm not sure which of these errors that maps to. If they happen to be generate in their listed order, it would correspond to {{invalid character in header}}. If I edit the response headers that are defined at the links above, the error code will change, so it seems we may need to tweak these responses to play nicely with the new version of http-parser.

> SSLTest.HTTPSPost and SSLTest.HTTPSGet tests fail
> -------------------------------------------------
>
>                 Key: MESOS-5063
>                 URL: https://issues.apache.org/jira/browse/MESOS-5063
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess
>    Affects Versions: 0.28.0
>         Environment: Configured with SSL enabled
>            Reporter: Greg Mann
>            Assignee: Greg Mann
>            Priority: Critical
>              Labels: mesosphere, ssl, tests
>
> These tests fail, with minimal logging output:
> {code}
> [ RUN      ] SSLTest.HTTPSGet
> ../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:663: Failure
> (response).failure(): Failed to decode response
> [  FAILED  ] SSLTest.HTTPSGet (137 ms)
> [ RUN      ] SSLTest.HTTPSPost
> ../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:704: Failure
> (response).failure(): Failed to decode response
> [  FAILED  ] SSLTest.HTTPSPost (243 ms)
> {code}
> It's worth noting that the 3rdparty http-parser library was recently upgraded: https://github.com/apache/mesos/commit/94df63f72146501872a06c6487e94bdfd0f23025



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)